Skip to content

[WIP] ci: add job to execute miri tests in test.yml workflow #4671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
syl20bnr wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[WIP] ci: add job to execute miri tests in test.yml workflow #4671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
edcd92d
ci: add job to execute miri tests in test.yml workflow
syl20bnr Mar 25, 2026
1182cf5
chore: update xtask and remove the version from xtask crate
syl20bnr Mar 25, 2026
e6fa116
feat: use xtask CLI in test.yml workflow
syl20bnr Mar 25, 2026
da46ee4
fix: compilation of xtask
syl20bnr Mar 25, 2026
f02858b
chore: update version of install-rust gh action
syl20bnr Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test-gpu.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
uses: actions/checkout@v6
# --------------------------------------------------------------------------------
- name: Install Rust
uses: tracel-ai/github-actions/install-rust@v9
uses: tracel-ai/github-actions/install-rust@v10
with:
rust-toolchain: ${{ matrix.toolchain }}
enable-cache: false
Expand Down Expand Up @@ -115,7 +115,7 @@ jobs:
uses: actions/checkout@v6
# --------------------------------------------------------------------------------
- name: Setup Rust
uses: tracel-ai/github-actions/install-rust@v9
uses: tracel-ai/github-actions/install-rust@v10
with:
rust-toolchain: ${{ matrix.toolchain }}
enable-cache: false
Expand Down Expand Up @@ -153,7 +153,7 @@ jobs:
uses: actions/checkout@v6
# --------------------------------------------------------------------------------
- name: Setup Rust
uses: tracel-ai/github-actions/install-rust@v9
uses: tracel-ai/github-actions/install-rust@v10
with:
rust-toolchain: ${{ matrix.toolchain }}
enable-cache: false
Expand Down
65 changes: 46 additions & 19 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,27 +71,27 @@ jobs:
uses: actions/checkout@v6
# --------------------------------------------------------------------------------
- name: Setup Rust
uses: tracel-ai/github-actions/install-rust@v9
uses: tracel-ai/github-actions/install-rust@v10
with:
rust-toolchain: ${{ matrix.toolchain }}
cache-key: ${{ matrix.rust }}-linux
# --------------------------------------------------------------------------------
- name: Audit
run: cargo xtask check audit
run: xtask check audit
# --------------------------------------------------------------------------------
- name: Format
shell: bash
env:
# work around for colors
# see: https://github.com/rust-lang/rustfmt/issues/3385
TERM: xterm-256color
run: cargo xtask check format
run: xtask check format
# --------------------------------------------------------------------------------
- name: Lint
run: cargo xtask check lint
run: xtask check lint
# --------------------------------------------------------------------------------
- name: Typos
uses: tracel-ai/github-actions/check-typos@v9
uses: tracel-ai/github-actions/check-typos@v10

documentation:
runs-on: ubuntu-22.04
Expand All @@ -107,16 +107,16 @@ jobs:
uses: actions/checkout@v6
# --------------------------------------------------------------------------------
- name: Setup Rust
uses: tracel-ai/github-actions/install-rust@v9
uses: tracel-ai/github-actions/install-rust@v10
with:
rust-toolchain: ${{ matrix.toolchain }}
cache-key: ${{ matrix.rust }}-linux
# --------------------------------------------------------------------------------
- name: Documentation Build
run: cargo xtask doc build
run: xtask doc build
# --------------------------------------------------------------------------------
- name: Documentation Tests
run: cargo xtask doc tests
run: xtask doc tests

linux-std-tests:
runs-on: ubuntu-22.04
Expand All @@ -139,7 +139,7 @@ jobs:
uses: actions/checkout@v6
# --------------------------------------------------------------------------------
- name: Setup Rust
uses: tracel-ai/github-actions/install-rust@v9
uses: tracel-ai/github-actions/install-rust@v10
with:
rust-toolchain: ${{ matrix.toolchain }}
cache-key: ${{ matrix.rust }}-linux
Expand All @@ -152,15 +152,15 @@ jobs:
run: |
curl -L "$GRCOV_LINK/v$GRCOV_VERSION/grcov-x86_64-unknown-linux-musl.tar.bz2" |
tar xj -C $HOME/.cargo/bin
cargo xtask coverage install
xtask coverage install
# --------------------------------------------------------------------------------
- name: Tests
run: cargo xtask ${{ matrix.coverage }} test ${{ env.TEST_RELEASE_FLAG }} --ci github-runner
run: xtask ${{ matrix.coverage }} test ${{ env.TEST_RELEASE_FLAG }} --ci github-runner
# --------------------------------------------------------------------------------
- name: Generate lcov.info
if: matrix.rust == 'stable'
# /* is to exclude std library code coverage from analysis
run: cargo xtask coverage generate --ignore "/*,xtask/*,examples/*" --profile release
run: xtask coverage generate --ignore "/*,xtask/*,examples/*" --profile release
# --------------------------------------------------------------------------------
- name: Codecov upload lcov.info
if: matrix.rust == 'stable'
Expand All @@ -185,16 +185,43 @@ jobs:
uses: actions/checkout@v6
# --------------------------------------------------------------------------------
- name: Setup Rust
uses: tracel-ai/github-actions/install-rust@v9
uses: tracel-ai/github-actions/install-rust@v10
with:
rust-toolchain: ${{ matrix.toolchain }}
cache-key: ${{ matrix.rust }}-linux-no-std
# --------------------------------------------------------------------------------
- name: Crates Build
run: cargo xtask --context no-std build --ci
run: xtask --context no-std build --ci
# --------------------------------------------------------------------------------
- name: Crates Tests
run: cargo xtask --context no-std test ${{ env.TEST_RELEASE_FLAG }} --ci github-runner
run: xtask --context no-std test ${{ env.TEST_RELEASE_FLAG }} --ci github-runner

linux-miri-tests:
runs-on: ubuntu-22.04
needs: [prepare-checks, code-quality]
env:
DISABLE_WGPU_SPIRV: "1"
# disable incremental compilation (reduces artifact size)
CARGO_PROFILE_TEST_INCREMENTAL: "false"
strategy:
matrix:
rust: [nightly]
include:
- rust: nightly
toolchain: nightly
steps:
- name: checkout
uses: actions/checkout@v6
# --------------------------------------------------------------------------------
- name: Setup Rust
uses: tracel-ai/github-actions/install-rust@v10
with:
rust-toolchain: ${{ matrix.toolchain }}
cache-key: ${{ matrix.rust }}-miri-tests
enable-cache: false
# --------------------------------------------------------------------------------
- name: Tests
run: xtask +n test --miri --ci github-runner

windows-std-tests:
runs-on: windows-2022
Expand All @@ -211,13 +238,13 @@ jobs:
uses: actions/checkout@v6
# --------------------------------------------------------------------------------
- name: Setup Rust
uses: tracel-ai/github-actions/install-rust@v9
uses: tracel-ai/github-actions/install-rust@v10
with:
rust-toolchain: ${{ matrix.toolchain }}
cache-key: ${{ matrix.rust }}-windows
# --------------------------------------------------------------------------------
- name: Tests
run: cargo xtask test ${{ env.TEST_RELEASE_FLAG }} --ci github-runner
run: xtask test ${{ env.TEST_RELEASE_FLAG }} --ci github-runner

macos-std-tests:
runs-on: blaze/macos-15
Expand All @@ -235,7 +262,7 @@ jobs:
uses: actions/checkout@v6
# --------------------------------------------------------------------------------
- name: Setup Rust
uses: tracel-ai/github-actions/install-rust@v9
uses: tracel-ai/github-actions/install-rust@v10
with:
rust-toolchain: ${{ matrix.toolchain }}
cache-key: ${{ matrix.rust }}-macos
Expand All @@ -244,4 +271,4 @@ jobs:
run: system_profiler SPHardwareDataType
# --------------------------------------------------------------------------------
- name: Tests
run: cargo xtask test ${{ env.TEST_RELEASE_FLAG }} --ci github-mac-runner
run: xtask test ${{ env.TEST_RELEASE_FLAG }} --ci github-mac-runner
10 changes: 5 additions & 5 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ cubek = { git = "https://github.com/tracel-ai/cubek", default-features = false,
# cubek = { version = "=0.2.0-pre.2", default-features = false }

### For xtask crate ###
tracel-xtask = "=4.13.5"
tracel-xtask = "=4.14.1"
# ### For local development. ###
# tracel-xtask = { path = "../xtask/crates/tracel-xtask", default-features = false }

Expand Down
2 changes: 1 addition & 1 deletion xtask/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "xtask"
version = "4.10.0"
version = "0.0.0"
edition.workspace = true
license = "MIT OR Apache-2.0"

Expand Down
1 change: 1 addition & 0 deletions xtask/src/commands/test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@ pub(crate) fn handle_command(
test: args.test.clone(),
force: args.force,
no_capture: args.no_capture,
miri: args.miri,
},
env.clone(),
ctx.clone(),
Expand Down
2 changes: 2 additions & 0 deletions xtask/src/commands/validate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ pub fn handle_command(
no_capture: false,
release: args.release,
test: None,
miri: false,
},
env.clone(),
Context::NoStd,
Expand Down Expand Up @@ -122,6 +123,7 @@ pub fn handle_command(
test: None,
force: false,
no_capture: false,
miri: false,
},
env.clone(),
Context::Std,
Expand Down
Loading