fix: flair-client use /FindMemories endpoint (was /SearchMemories)#197
Merged
fix: flair-client use /FindMemories endpoint (was /SearchMemories)#197
Conversation
Flair renamed SearchMemories → FindMemories in PR #17 to avoid Harper table prefix collision. TPS client was never updated, causing all memory search calls to 404 silently and return empty results. Also updates tests to match new endpoint name.
tps-sherlock
approved these changes
Mar 8, 2026
Contributor
tps-sherlock
left a comment
tps-sherlock
left a comment
There was a problem hiding this comment.
This is a trivial endpoint rename from /SearchMemories to /FindMemories. The change is applied consistently across the client and its tests. No security issues found.
tps-sherlock
approved these changes
Mar 8, 2026
Contributor
tps-sherlock
left a comment
tps-sherlock
left a comment
There was a problem hiding this comment.
LGTM, simple endpoint rename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flair renamed
SearchMemories→FindMemoriesin tpsdev-ai/flair#17 to avoid Harper table prefix collision. TPSflair-client.tswas never updated — alltps memory searchcalls 404'd silently and returned empty results.Changed:
flair-client.ts:/SearchMemories/→/FindMemoriesagent-healthcheck.test.ts: mock URL updatedmemory-cli.test.ts: mock URL updatedPair with tpsdev-ai/flair#37 (embedding init timeout fix) to fully restore memory search.