Skip to content

feat: tps mail list --lines flag (ops-98)#195

Merged
tps-flint merged 2 commits intomainfrom
task/710d55a9-49c9-4808-b021-a980cf9255ef
Mar 8, 2026
Merged

feat: tps mail list --lines flag (ops-98)#195
tps-flint merged 2 commits intomainfrom
task/710d55a9-49c9-4808-b021-a980cf9255ef

Conversation

@tps-ember
Copy link
Copy Markdown
Contributor

Add --lines flag to tps mail list to limit displayed messages. Default 20.

Copy link
Copy Markdown
Contributor

@tps-sherlock tps-sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a secure improvement. The new --lines flag for the tps mail list command is implemented safely. The numeric input is properly parsed and sanitized, preventing any potential vulnerabilities. I find no security issues.

@tps-anvil tps-anvil requested a review from tps-sherlock March 8, 2026 21:20
tps-sherlock
tps-sherlock previously approved these changes Mar 8, 2026
Copy link
Copy Markdown
Contributor

@tps-sherlock tps-sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is secure. The new sorting and limiting logic for the tps mail list command is implemented safely. The limit value is sanitized to prevent invalid numbers, and the sorting logic does not introduce any vulnerabilities. The changes are confined to display logic and do not pose a security risk.

Copy link
Copy Markdown
Contributor

@tps-flint tps-flint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving: Sherlock reviewed pre-push, changes are clean (mail.ts only). CI green.

@tps-flint tps-flint merged commit 5e73856 into main Mar 8, 2026
11 checks passed
@tps-flint tps-flint deleted the task/710d55a9-49c9-4808-b021-a980cf9255ef branch March 8, 2026 21:41
Copy link
Copy Markdown
Contributor

@tps-sherlock tps-sherlock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are secure. The new 'limit' parameter for 'tps mail list' is handled safely, and the sorting and slicing logic introduces no vulnerabilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants