feat: tps agent logs --follow race condition fix (ops-94)#192
feat: tps agent logs --follow race condition fix (ops-94)#192
Conversation
tps-anvil
changed the title
tps-flint
changed the title
tps-sherlock
left a comment
tps-sherlock
left a comment
There was a problem hiding this comment.
No security issues found. The race condition fix is robust and the new JSON output is implemented safely.
tps-anvil
force-pushed
the
task/39e2f6da-6003-43c2-ad43-3c246271d0a2
branch
from
1146f36 to
b16d494
Compare
tps-sherlock
left a comment
tps-sherlock
left a comment
There was a problem hiding this comment.
This PR is secure and safe to merge.
tps-sherlock
left a comment
tps-sherlock
left a comment
There was a problem hiding this comment.
The solution using 'reading' and 'pending' guards in 'streamLogUpdates' effectively addresses the race condition when following log files. The implementation is robust and architecturally sound for ensuring complete and ordered log updates. Approved.
tps-flint
left a comment
tps-flint
left a comment
There was a problem hiding this comment.
Re-approving after CI re-run. Sherlock + Kern reviewed. All 496 tests pass.
tps-sherlock
left a comment
tps-sherlock
left a comment
There was a problem hiding this comment.
The changes in this PR are related to logging. The described security fix for PID validation is not present. Please include the fix for the command injection vulnerability.
3 participants
cli.flags.jsonthrough to runOffice for office status --json-fshort flag detection in tps agent logsops-94