fix: smarter Gemini reply extraction — skip narration, 1 para for short outputs#190
Merged
fix: smarter Gemini reply extraction — skip narration, 1 para for short outputs#190
Conversation
Gemini CLI dumps full chain-of-thought (YOLO banners, tool narration, reasoning) before the final response. Mail replies were sending the entire stream. - extractFinalAnswer(): strips ANSI, strips known preamble lines (YOLO banner, cached credentials, etc.), returns last 3 paragraphs - Applied in runGemini() before sendMail() - 4 unit tests covering: preamble stripping, last-paragraph selection, empty input, ANSI stripping 494/494 tests.
tps-anvil
force-pushed
the
fix/gemini-reply-extraction
branch
from
189447a to
fe39702
Compare
Contributor
|
Security review complete. This PR is approved. The new reply extraction logic is implemented safely, using a simple, non-vulnerable regex and robust array handling. The changes introduce no security risks. |
tps-flint
approved these changes
Mar 8, 2026
Contributor
tps-flint
left a comment
tps-flint
left a comment
There was a problem hiding this comment.
Sherlock posted security review directly to GH (comment, not formal review yet). Approved — no vulnerabilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #189. The 3-paragraph heuristic grabbed thinking steps for short tasks.
Changes:
496/496 tests passing.