fix gate-ing of atomic64 in tests#607
Merged
jlizen merged 3 commits intotower-rs:mainfrom May 6, 2026
Merged
Conversation
alexanderkjall
force-pushed
the
fix-atomic-test
branch
from
8af7e91 to
fe17584
Compare
jplatte
reviewed
Dec 25, 2025
Member
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
How about switching to AtomicU16? Would that allow the tests to run on the architectures in question?
Member
|
@alexanderkjall I think That will get rid of the cfg flags, which will be nicer to maintain. Are you interested in cutting another commit? |
alexanderkjall
force-pushed
the
fix-atomic-test
branch
from
2782415 to
e6ca208
Compare
Contributor
Author
|
Sure, replaced AtomicU64 with AtomicUsize, also switched it out in a doctest. |
eleboucher
pushed a commit
to eleboucher/towonel
that referenced
this pull request
May 9, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [tower-http](https://github.com/tower-rs/tower-http) | workspace.dependencies | patch | `0.6.9` → `0.6.10` | --- ### Release Notes <details> <summary>tower-rs/tower-http (tower-http)</summary> ### [`v0.6.10`](https://github.com/tower-rs/tower-http/releases/tag/tower-http-0.6.10) [Compare Source](tower-rs/tower-http@tower-http-0.6.9...tower-http-0.6.10) #### Added - `follow-redirect`: expose `Attempt::method()` and `Attempt::previous_method()` so redirect policies can react to method changes across redirects (e.g. POST to GET on 301/303) ([#​559]) #### Fixed - Restore `tokio` and `async-compression` as no-op features. These will be removed next breaking release ([#​667]) [#​559]: tower-rs/tower-http#559 [#​667]: tower-rs/tower-http#667 #### What's Changed - fix: restore tokio and async-compression as no-op features by [@​jlizen](https://github.com/jlizen) in [#​667](tower-rs/tower-http#667) - fix gate-ing of atomic64 in tests by [@​alexanderkjall](https://github.com/alexanderkjall) in [#​607](tower-rs/tower-http#607) - follow\_redirect: expose previous and next request methods by [@​lucab](https://github.com/lucab) in [#​559](tower-rs/tower-http#559) - chore: release tower-http 0.6.10 by [@​jlizen](https://github.com/jlizen) in [#​669](tower-rs/tower-http#669) #### New Contributors - [@​lucab](https://github.com/lucab) made their first contribution in [#​559](tower-rs/tower-http#559) **Full Changelog**: <tower-rs/tower-http@tower-http-0.6.9...tower-http-0.6.10> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJ0eXBlL3BhdGNoIl19--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/towonel/pulls/34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes tests on some architectures.
based on: https://salsa.debian.org/rust-team/debcargo-conf/-/blob/master/src/tower-http/debian/patches/gate-tests-atomic-u64
Solution
use
#[cfg(target_has_atomic = "64")]