Skip to content

Fix locale warnings#200

Open
denismosolov wants to merge 1 commit intomasterfrom
locale-warning
Open

Fix locale warnings#200
denismosolov wants to merge 1 commit intomasterfrom
locale-warning

Conversation

@denismosolov
Copy link
Copy Markdown
Contributor

@denismosolov denismosolov commented Jun 17, 2019

Please make sure all below checkboxes in the Mandatory section have been checked before submitting your PR (also don't forget to pay attention to the Depending on Circumstances section)

Mandatory

  • The commit message is an imperative and starts with a capital letter (for example, Add something, Remove something, Fix something, etc.).
  • I made sure I hadn't put a period at the end of the the commit message(s).

Depending on Circumstances

Some of the items in the section become mandatory if you are a first-time contributor and/or your changes are relevant to the items.

  • Adding a new parameter I didn't forget to reflect it in README.md.
  • Adding a new parameter or modifying an existing one I didn't break the alphabetical order.
  • Adding a new utility written in Python I didn't forget to reflect it in pieman/README.md.
  • Adding a new utility written in Python I didn't forget to increase the version number of the pieman package in pieman/setup.py, pieman/pieman/__init__.py and essentials.sh.
  • (for first-time contributors) One of the commits in the pull request adds me to the Acknowledgements section in AUTHORS.md.

@denismosolov denismosolov requested review from a user and eugulixes June 17, 2019 08:47
Copy link
Copy Markdown
Contributor

@eugulixes eugulixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, provide an example of the warning. As far as I remember, only Ubuntu Bionic has such problem, but the fix is applied to all supported distros in Pieman and it is redundant, I guess.

@denismosolov
Copy link
Copy Markdown
Contributor Author

denismosolov commented Jun 17, 2019

@eugulixes I can see this when building ubuntu-bionic-armhf
Selection_704
I will test other distros later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants