Skip to content

fix: prevent Quick Start panel from reopening after user closes it#3522

Open
Anty0 wants to merge 1 commit intomainfrom
jirikuchynka/fix-quickstart-reopen
Open

fix: prevent Quick Start panel from reopening after user closes it#3522
Anty0 wants to merge 1 commit intomainfrom
jirikuchynka/fix-quickstart-reopen

Conversation

@Anty0
Copy link
Copy Markdown
Collaborator

@Anty0 Anty0 commented Mar 11, 2026

Summary

  • Remove unconditional setQuickStartOpen(true) call in the translations view that overrode the user's manual close of the Quick Start panel
  • The floatingForced mechanism alone correctly handles the layout transition between the Quick Start sidebar and the translation side panel
  • Fixes the panel reopening when stopping translation editing or reloading the page after manually closing it

Summary by CodeRabbit

  • Bug Fixes
    • Quick start panel no longer automatically opens when side-panel width or quick-start settings change; only the floating state is now affected.

The translations view was unconditionally calling setQuickStartOpen(true)
when the side panel opened, overriding the user's manual close and
persisting open=true to the backend. Remove that call so the
floatingForced mechanism alone handles the layout transition.
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 11, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 429c5530-387e-4137-b2cd-fe94aeb6795f

📥 Commits

Reviewing files that changed from the base of the PR and between 89813a6 and d5ce360.

📒 Files selected for processing (1)
  • webapp/src/views/projects/translations/Translations.tsx

📝 Walkthrough

Walkthrough

A code adjustment in the Translations component removes automatic quick-start panel opening while retaining the floating state enforcement. The change reduces reliance on the setQuickStartOpen action, keeping only setQuickStartFloatingForced.

Changes

Cohort / File(s) Summary
Quick-Start Panel Initialization
webapp/src/views/projects/translations/Translations.tsx
Removed automatic quick-start panel opening from the side-panel width/enablement effect. Now only forces the floating state without explicitly opening the panel; eliminated dependency on setQuickStartOpen action.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • JanCizmar

Poem

🐰 The quick-start panel once would spring,
Unbidden, with an eager swing,
Now gently it waits, just floating free,
Less pushy, more polite you see! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: preventing the Quick Start panel from automatically reopening after a user closes it.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jirikuchynka/fix-quickstart-reopen

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant