Skip to content

Avoid overriding systemd unit/settings when not configured to do so#122

Open
carlpett wants to merge 1 commit intotmux-plugins:masterfrom
carlpett:avoid-overriding-systemd-unit
Open

Avoid overriding systemd unit/settings when not configured to do so#122
carlpett wants to merge 1 commit intotmux-plugins:masterfrom
carlpett:avoid-overriding-systemd-unit

Conversation

@carlpett
Copy link
Copy Markdown

Fixes #121, #73.

Currently, if the user has their own tmux.service file and does not enable continuum-boot, tmux-continuum will disable it on startup. This PR adds a check to try to ensure it only makes changes if it matches the user intent to have it do so.

@bruno-
Copy link
Copy Markdown
Member

bruno- commented Feb 24, 2023

Pinging @nuclearglow because it's a systemd-related change.

Copy link
Copy Markdown

@nuclearglow nuclearglow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@promisedlandt
Copy link
Copy Markdown

I would be very happy if this could be merged, since I have the exact issue this solves 😃

@carlpett
Copy link
Copy Markdown
Author

carlpett commented Mar 4, 2024

@bruno- Do you expect to merge this? Doing some spring cleaning of my open PRs 🧹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Systemd user service disabled even if not managed by continuum

4 participants