Change cache settings to decrease latency on most queries#348
Open
brian-lawrence-math wants to merge 2 commits into
Open
Change cache settings to decrease latency on most queries#348brian-lawrence-math wants to merge 2 commits into
brian-lawrence-math wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I run the simple invocation
tldr <command>, the code typically fetches the page from the internet, resulting in a 3-5 second delay before the tldr page displays. I think this is caused by cache settings:The delay is annoying. I'd suggest changing default behavior to make more use of the cache. Here (this PR) is one proposal:
tldr <command>first runstldr <command>is run and the cache hasn't been updated in at least one monthtldr -uto force a manual update.--
Notes and tradeoffs.
Cost to store all the pages? The cache with all the pages (English, all platforms) is ~28MB -- small. No harm in downloading and storing it.
Need to update pages frequently? Only a small fraction of pages are updated in any given month, and very few of those updates are critical. Look at modified dates on the tldr repo.
--
Yes, I know I can avoid this issue in other ways.
tldr -uevery weekBut more aggressive caching is a better default for new users.