refactor warning popups + support keybindings#2807
Merged
Conversation
tildearrow
requested changes
Feb 21, 2026
Owner
tildearrow
left a comment
tildearrow
left a comment
There was a problem hiding this comment.
I have no time for development, so I'll merge this after your answer
the warnIsOpen check here is kinda wonky... but `IsPopupOpen` was either crashing or reporting wrong values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal here was primarily to add key shortcuts for the options in the warnings. I decided to refactor it so there's now
struct FurnaceGUI::WarnChoice, which represents one of the choice buttons in a warning pop-up (text, key, action callback & whether it's destructive).Only exception to this was for
GUI_WARN_CLEAR, which doesn't follow this logic.