Conversation
thomhurst
added
dependencies
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit 1.17.25 → 1.17.29
This is a straightforward Renovate Bot dependency bump for three TUnit packages:
TUnit1.17.25 → 1.17.29TUnit.Assertions1.17.25 → 1.17.29TUnit.Core1.17.25 → 1.17.29
Assessment: Looks good ✓
The update is clean and well-structured:
- All three TUnit packages are kept in sync at the same version (1.17.29), which is correct as they are part of the same framework and should always be updated together.
- The change is confined to
Directory.Packages.props, which is the correct centralized location for managing NuGet package versions in this repo. - The TUnit 1.17.29 release notes indicate minor additions (span return support in mocks) and internal refactoring — no breaking changes noted.
- Codacy, CodeFactor, and Snyk checks are all passing for this PR.
No concerns. Safe to merge once CI pipelines complete.
thomhurst
force-pushed
the
renovate/tunit
branch
from
9cadd33 to
d05b536
Compare
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
changed the title
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit 1.17.25 → 1.17.36
This is a Renovate Bot dependency bump for three TUnit packages:
TUnit1.17.25 → 1.17.36TUnit.Assertions1.17.25 → 1.17.36TUnit.Core1.17.25 → 1.17.36
Note on Previous Review: A previous review was posted when the target was 1.17.29. The PR has since been rebased/updated to target 1.17.36. This review covers the full range.
Assessment: Looks good ✓
The update is clean and correct:
- Version consistency: All three TUnit packages remain in sync at 1.17.36, which is required — they are part of the same framework and must always be updated together.
- Correct location: Changes are confined to
Directory.Packages.props, the centralized package version management file. Individual.csprojfiles don't need to be touched. - Changelog highlights (1.17.25 → 1.17.36):
- Mock API improvements: concise inline lambda API, untyped
Any(), span return.Returns()support - Refactoring of Mock control members to static helpers
- Internal dependency updates (no breaking changes noted)
- Mock API improvements: concise inline lambda API, untyped
- The changes are purely additive/refinements in the mocking API — no breaking changes that would affect this repo's test suite.
No architectural concerns. Safe to merge once CI pipelines complete.
thomhurst
force-pushed
the
renovate/tunit
branch
from
d05b536 to
1a00dcb
Compare
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
changed the title
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit 1.17.25 → 1.17.54
This is a Renovate Bot dependency bump for three TUnit packages (the PR has been rebased/updated again since prior reviews at 1.17.29 and 1.17.36):
TUnit1.17.25 → 1.17.54TUnit.Assertions1.17.25 → 1.17.54TUnit.Core1.17.25 → 1.17.54
Assessment: Looks good
The change is correct and well-structured:
- Version consistency: All three TUnit packages are kept in sync at the same version (1.17.54). Since
TUnit,TUnit.Assertions, andTUnit.Coreare part of the same framework and share internal coupling, keeping them at the same version is required to avoid unexpected runtime or compilation errors. - Correct location: The change is confined to
Directory.Packages.props, which is the right centralized place for NuGet version management in this repo. No individual.csprojfiles need modification, which is the expected pattern when using Central Package Management (CPM). - Changelog highlights (1.17.36 → 1.17.54):
- New assertions:
IsAssignableFrom<T>()andIsNotAssignableFrom<T>()added to the assertions API — purely additive. - Bug fix: GitHub reporter summary newline fix for improved rendering.
- Documentation restructuring — no behavioral changes.
- No breaking changes noted across any of the intermediate releases.
- New assertions:
Since these changes are purely additive (new assertions) plus a minor bug fix, and no breaking changes are indicated, there is no risk of existing tests in this repo being disrupted by the update.
No concerns. Safe to merge once CI pipelines complete.
thomhurst
force-pushed
the
renovate/tunit
branch
from
1a00dcb to
b6e9e16
Compare
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit 1.17.25 → 1.17.54 (Follow-up)
This PR continues to show the same clean dependency bump as covered in the previous reviews. The current diff remains identical to what was reviewed on 2026-02-27:
TUnit1.17.25 → 1.17.54TUnit.Assertions1.17.25 → 1.17.54TUnit.Core1.17.25 → 1.17.54
Previous Reviews: Addressed ✓
All previous review points remain valid and there are no new concerns:
- Version consistency: All three packages remain in sync at 1.17.54 — correct.
- Correct location: Change confined to
Directory.Packages.props(Central Package Management) — correct. - No breaking changes: The intermediate releases (1.17.25 → 1.17.54) include only additive features (new assertions
IsAssignableFrom<T>/IsNotAssignableFrom<T>()), a minor GitHub reporter rendering fix, and documentation updates.
CI Status
CI pipelines are currently pending. CodeFactor and Snyk are already passing with no issues.
No concerns with the code change itself. Safe to merge once CI pipelines complete.
thomhurst
force-pushed
the
renovate/tunit
branch
from
b6e9e16 to
5888ba9
Compare
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
changed the title
There was a problem hiding this comment.
Dependency Update Review: TUnit 1.17.25 → 1.19.0
This is a straightforward Renovate-generated dependency bump updating all three TUnit packages in lock-step:
TUnit1.17.25 → 1.19.0TUnit.Assertions1.17.25 → 1.19.0TUnit.Core1.17.25 → 1.19.0
Assessment: ✅ Safe to merge
What's in this update:
The version jump covers multiple releases with a mix of fixes and performance improvements:
- Bug fixes: Improved
CreateTestVariantAPI, void/ValueTask return type fixes, C# keyword parameter name escaping in mock generation,IsEquivalentTofallback toEquals()for types with no public members, parent data source span initialization fix. - Performance: Source-gen JIT overhead reduction (~18,000–27,000 fewer JITs via per-class consolidation),
Actionallocation removal fortoken.Register, synchronous test metadata creation, lazyReflectionInforesolution. - Features: Rich HTML test reports with distributed trace collection,
IsAssignableFrom<T>()/IsNotAssignableFrom<T>()assertions, static abstract interface member support in mock generation.
Change quality:
The change is minimal — only 3 lines modified in Directory.Packages.props, all three packages updated to the same version (1.19.0), which is the correct approach for keeping TUnit packages in sync. No code changes are required on the consumer side.
No concerns. This is a minor version bump with no breaking changes noted, automerge is already enabled for this bot-generated PR.
thomhurst
force-pushed
the
renovate/tunit
branch
from
bc752ae to
b816475
Compare
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
There was a problem hiding this comment.
Dependency Update Review: TUnit 1.17.25 → 1.19.0 (Follow-up)
This PR continues to show the same clean dependency bump as reviewed on 2026-03-06. The current diff is unchanged from that review:
TUnit 1.17.25 → 1.19.0
TUnit.Assertions 1.17.25 → 1.19.0
TUnit.Core 1.17.25 → 1.19.0
Previous Reviews: Addressed ✓
All prior review points remain valid with no new concerns to raise:
- Version consistency: All three TUnit packages remain in sync at
1.19.0— correct and required given their shared internal coupling. - Correct location: Change is confined to
Directory.Packages.props(Central Package Management) — no individual.csprojfiles need modification. - No breaking changes: The full 1.17.25 → 1.19.0 range includes only additive features, performance improvements (JIT reduction, lazy metadata resolution), and targeted bug fixes (CreateTestVariant API, void/ValueTask return type fixes, mock C# keyword escaping).
No concerns. Safe to merge once CI pipelines complete.
There was a problem hiding this comment.
Dependency Update Review: TUnit 1.17.25 → 1.19.0 (Follow-up)
This PR continues to show the same clean dependency bump as reviewed on 2026-03-06. The current diff is unchanged from that review:
TUnit 1.17.25 → 1.19.0
TUnit.Assertions 1.17.25 → 1.19.0
TUnit.Core 1.17.25 → 1.19.0
Previous Reviews: Addressed ✓
All prior review points remain valid with no new concerns to raise:
- Version consistency: All three TUnit packages remain in sync at
1.19.0— correct and required given their shared internal coupling. - Correct location: Change is confined to
Directory.Packages.props(Central Package Management) — no individual.csprojfiles need modification. - No breaking changes: The full 1.17.25 → 1.19.0 range includes only additive features, performance improvements (JIT reduction, lazy metadata resolution), and targeted bug fixes (CreateTestVariant API, void/ValueTask return type fixes, mock C# keyword escaping).
No concerns. Safe to merge once CI pipelines complete.
thomhurst
force-pushed
the
renovate/tunit
branch
from
b816475 to
98ad2c4
Compare
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit 1.17.25 → 1.19.0
This is a Renovate Bot bump of three TUnit packages in Directory.Packages.props:
TUnit1.17.25 → 1.19.0TUnit.Assertions1.17.25 → 1.19.0TUnit.Core1.17.25 → 1.19.0
Assessment: Looks good ✓
The change is well-structured and correct:
- All three packages are kept in sync at the same version (1.19.0), which is important since TUnit, TUnit.Assertions, and TUnit.Core are part of the same framework and must always move together.
- The update is isolated to
Directory.Packages.props, the correct centralized location for NuGet package version management in this repo. - This is a minor version bump (1.17.x → 1.19.0), which typically implies no breaking changes. The release notes confirm the changes are improvements and fixes:
- 1.18.0: Performance improvements (reducing JIT compilations by ~45,000), rich HTML test reports, and assertion fixes.
- 1.18.9–1.18.37: Further perf improvements, HTML report perf, mock generation fixes (C# keyword escaping, static abstract interface members), and distributed trace collection.
- 1.19.0: Fix for
CreateTestVariantAPI and void/ValueTask return types.
No API breaking changes are noted across the release notes. Given that ModularPipelines uses TUnit as its test framework, the HTML report and performance improvements are a welcome addition.
Previous review coverage: A prior Claude review covered the 1.17.25 → 1.17.29 step; this PR has since been updated to target 1.19.0. The same conclusions apply — no concerns.
Safe to merge once CI passes.
thomhurst
force-pushed
the
renovate/tunit
branch
from
98ad2c4 to
58d695d
Compare
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
had a problem deploying
to
Pull Requests
GitHub Actions
Failure
thomhurst
changed the title
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit 1.17.25 → 1.19.11
This is a Renovate Bot dependency bump for three TUnit packages:
TUnit1.17.25 → 1.19.11TUnit.Assertions1.17.25 → 1.19.11TUnit.Core1.17.25 → 1.19.11
Assessment: Looks good ✓
The update is clean and well-structured:
- All three TUnit packages are kept in sync at the same version (1.19.11), which is correct — they are part of the same framework and must always be updated together to avoid compatibility issues.
- The change is properly confined to
Directory.Packages.props, the centralized NuGet version management file for this repo. - The version jump spans several minor releases (1.17.25 → 1.19.11), but reviewing the release notes, all changes are non-breaking: HTML report fixes/perf improvements, mock generation fixes, redundant allocation reductions, and internal refactoring. No API-breaking changes noted.
- The
CreateTestVariantAPI improvement in 1.19.0 and static abstract interface mock support in 1.18.37 are additive features only.
Previous review context: A prior review covered an earlier bump to 1.17.29. This PR continues the incremental update pattern — no prior review concerns remain unaddressed.
No concerns. Safe to merge once CI passes.
thomhurst
force-pushed
the
renovate/tunit
branch
from
58d695d to
b3aba42
Compare
thomhurst
changed the title
There was a problem hiding this comment.
Code Review: Dependency Update - TUnit 1.17.25 → 1.19.16
This is a Renovate Bot dependency bump spanning multiple TUnit releases for three packages:
TUnit1.17.25 → 1.19.16TUnit.Assertions1.17.25 → 1.19.16TUnit.Core1.17.25 → 1.19.16
Assessment: Looks good ✓
Previous Review Status: A prior Claude review was posted when this PR targeted 1.17.29. The PR has since been rebased/updated to target 1.19.16. The same analysis applies and remains valid.
Change Quality:
- All three TUnit packages remain in sync at the same version (1.19.16), which is correct — they are part of the same framework and must be versioned together.
- The change is appropriately confined to
Directory.Packages.props, the centralized NuGet version management file. No individual project files were touched, which is the right pattern for Central Package Management.
Notable changes across the included releases (1.17.25 → 1.19.16):
- Performance improvements: reduced JIT overhead, fewer allocations, synchronous test metadata creation
- New features: rich HTML test reports, distributed trace collection,
IsAssignableFrom<T>()assertions, improved mock API - Bug fixes: GitHub summary rendering, HTML report sort, C# keyword escaping in mock generation,
IsEquivalentTo()fallback - No breaking changes noted across any of the intermediate releases
No concerns. This is a safe, clean update that follows the repo's centralized package management conventions. Safe to merge once CI pipelines complete.
2 participants
This PR contains the following updates:
1.17.25→1.19.161.17.25→1.19.161.17.25→1.19.16Release Notes
thomhurst/TUnit (TUnit)
v1.19.16: 1.19.16What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.19.11...v1.19.16
v1.19.11: 1.19.11What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.19.0...v1.19.11
v1.19.0: 1.19.0What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.18.37...v1.19.0
v1.18.37: 1.18.37What's Changed
Other Changes
Actionallocation fortoken.Registerby @TimothyMakkison in #5075Dependencies
Full Changelog: thomhurst/TUnit@v1.18.21...v1.18.37
v1.18.21: 1.18.21What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.18.9...v1.18.21
v1.18.9: 1.18.9What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.18.0...v1.18.9
v1.18.0: 1.18.0What's Changed
Other Changes
--results-directoryin documentation by @vbreuss in #5038Dependencies
Full Changelog: thomhurst/TUnit@v1.17.54...v1.18.0
v1.17.54: 1.17.54What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.17.36...v1.17.54
v1.17.36: 1.17.36What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.17.29...v1.17.36
v1.17.29: 1.17.29What's Changed
Other Changes
Dependencies
Full Changelog: thomhurst/TUnit@v1.17.25...v1.17.29
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.