Skip to content

Fix proxy wait for response#248

Open
pedrosimeao-7egend wants to merge 1 commit into
testinggospels:developfrom
pedrosimeao-7egend:fix/proxy-wait-for-response
Open

Fix proxy wait for response#248
pedrosimeao-7egend wants to merge 1 commit into
testinggospels:developfrom
pedrosimeao-7egend:fix/proxy-wait-for-response

Conversation

@pedrosimeao-7egend
Copy link
Copy Markdown

@pedrosimeao-7egend pedrosimeao-7egend commented Feb 20, 2024

Description

This PR includes 3 fixes:

  1. Proxy was not waiting for response, so it didn't work
  2. Proxy configuration requires optional ssl option
  3. On parser error, the response status code was 200 (replaced to 500)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Test Configuration:

{
    "target": "https://random-data-api.com/api/users/random_user",
    "followRedirects": false,
    "changeOrigin": true,
    "ignorePath": true
}
  • OS: MacOS
  • Node version: 20.11.0
  • NPM Version: 10.2.4

Checklist:

  • My code follows the guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • This does not break any existing functionalities
  • Any dependent changes have been merged and published in downstream modules

@pedrosimeao-7egend
Copy link
Copy Markdown
Author

@shubhendumadhukar any chance to get this into a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant