Fix masked_scatter decomposition to resolve OOM error in gemma3 multimodal models#4315
Draft
sonalibaskaran2499 wants to merge 1 commit intomainfrom
Draft
Fix masked_scatter decomposition to resolve OOM error in gemma3 multimodal models#4315sonalibaskaran2499 wants to merge 1 commit intomainfrom
sonalibaskaran2499 wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4315 +/- ##
==========================================
+ Coverage 27.16% 32.85% +5.69%
==========================================
Files 33 36 +3
Lines 4307 4690 +383
==========================================
+ Hits 1170 1541 +371
- Misses 3137 3149 +12 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Link to Github Issue
Problem description
Gemma 3 multimodal variants was failed with the OOM error
Out of Memory: Not enough space to allocate 2904555520 B DRAM buffer across 12 banks, where each bank needs to store 242049024 B, but bank size is 1071821792 B
What's changed
Resolved the OOM error by adding a fast path for the common case where the mask is row-constant. Instead of running cumsum over the full B×S×H flat tensor (709k elements) detect this via mask.stride(-1) == 0 and run cumsum only over the B×S token dimension (277 elements), then gather entire feature rows at once.
Checklist