Chore(deps): Bump androidx.compose.runtime:runtime-livedata from 1.7.7 to 1.10.0#761
Conversation
Bumps androidx.compose.runtime:runtime-livedata from 1.7.7 to 1.10.0. --- updated-dependencies: - dependency-name: androidx.compose.runtime:runtime-livedata dependency-version: 1.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Greptile SummaryOverviewThis PR updates Critical Issue: Compose Version MismatchThe build configuration has a fundamental problem with how Compose dependencies are managed: Current State:
The Problem: More critically, mixing Compose 1.10.0 (
RecommendationsOption 1 (Recommended): Remove the explicit version and let the BOM manage it: implementation("androidx.compose.runtime:runtime-livedata") // Version managed by BOMOption 2: Upgrade the entire Compose stack together:
Additional FindingThere's also a minor version mismatch with the Kotlin serialization plugin (1.9.0 vs project Kotlin 1.9.23), though this is not directly related to this PR. Impact AssessmentRisk Level: High - This change is likely to break the build or cause runtime failures. |
Additional Comments (1)
The Issue:
Impact:
Recommendation:
This allows the BOM to manage the version and ensures all Compose dependencies are compatible. Prompt To Fix With AIThis is a comment left during a code review.
Path: samples/compose_app/build.gradle.kts
Line: 85:96
Comment:
**Critical Version Mismatch**: Upgrading `runtime-livedata` to 1.10.0 creates a significant incompatibility with the existing Compose setup:
**The Issue:**
- The Compose BOM `2024.04.01` (line 85) pins most Compose dependencies to version ~1.6.x
- This PR updates `runtime-livedata` to 1.10.0, which is from a much newer Compose release
- Compose 1.10.0 requires either:
- Kotlin 2.0+ (with no `kotlinCompilerExtensionVersion` specified), OR
- Kotlin 1.9.x with `kotlinCompilerExtensionVersion` 1.5.15+
- Current project uses Kotlin 1.9.23 with `kotlinCompilerExtensionVersion` 1.5.13 (line 62)
**Impact:**
This version mismatch can cause:
- Runtime crashes with ClassNotFoundExceptions
- Compilation errors due to binary incompatibilities between Compose versions
- Unexpected behavior in `observeAsState()` function used in `CallScreen.kt` (lines 107-109)
**Recommendation:**
Either:
1. **Upgrade all Compose dependencies together** by updating the BOM to `2024.12.01` or newer and updating `kotlinCompilerExtensionVersion` to 1.5.15, OR
2. **Keep runtime-livedata aligned with the BOM** by removing the explicit version and letting the BOM manage it
```suggestion
implementation("androidx.compose.runtime:runtime-livedata")
```
This allows the BOM to manage the version and ensures all Compose dependencies are compatible.
How can I resolve this? If you propose a fix, please make it concise. |
Bumps androidx.compose.runtime:runtime-livedata from 1.7.7 to 1.10.0.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)