Type correction in PlacedOrder#286
Merged
Graeme22 merged 1 commit intotastyware:masterfrom Nov 14, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The type of attribute replaces_order_id in PlacedOrder has been changed from str to int.
With that fix replacement of orders is working again now.
Maybe the attribute
replacing_order_idshould be changed as well, but in my case it had no value. I assume it is there for compatibility reasons only.Related issue(s)
Fixes #285
Pre-merge checklist
make lint)make test, make sure you haveTT_REFRESH,TT_SECRET, andTT_ACCOUNTenvironment variables set)Please note that, in order to pass the tests, you'll need to set up your Tastytrade credentials as repository secrets on your local fork. Read more at CONTRIBUTING.md.