fix(bill): move _PopularBillItem out of BillView and use static final…#108
Open
chennjustin wants to merge 1 commit intotaipei-doit:mainfrom
Open
fix(bill): move _PopularBillItem out of BillView and use static final…#108chennjustin wants to merge 1 commit intotaipei-doit:mainfrom
chennjustin wants to merge 1 commit intotaipei-doit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pull request 類型
Checklist
在提交 pull request 前請確認下列事項皆已確認。
受影響的 issue
Closes #107
額外說明
lib/page/bill/bill_view.dart在BillView內宣告_PopularBillItem，不符合 Dart 語法；且_popularBillItems使用static const搭配 FlutterGen 的Assets.svg….svg()，在 release／AOT 建置下會因非編譯期常數而編譯失敗。_PopularBillItem提升至檔案頂層；將熱門繳費列表改為static final，並簡述註解。lib/page/bill/bill_view.dart。