Conversation
Owner
|
What about tests? |
Owner
|
👍 |
Collaborator
Author
I'll work on at unit tests in parallel. I'm probably not going to add tests for the functionality in main but let's see how it goes. |
This was referenced Nov 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Platform IAM tokens in addition to the use of the in-cluster config.
It's disabled by default and can be enabled by setting the flag
--use-platform-credentials. By default it uses the canonical credential location at/meta/credentialsbut the location can be customised by either setting the flag--credentials-diror the environment variableCREDENTIALS_DIR.The reason for this change is to allow
egress-controllerto connect to multiple clusters using the same credentials, which isn't possible with in-cluster service account tokens. This first PR enables the use of different credentials. In a follow-up PR there will be changes to support multiple clusters.