fix(shield): support digest pinning for allowlist waiter image#2607
Merged
francesco-furlan merged 2 commits intomainfrom Apr 29, 2026
Merged
fix(shield): support digest pinning for allowlist waiter image#2607francesco-furlan merged 2 commits intomainfrom
francesco-furlan merged 2 commits intomainfrom
Conversation
Mirror the host/cluster/host_windows tag_separator pattern so the allowlist waiter image renders with `@` when the tag is a `sha256:` digest and `:` for regular tags. Without this, pinning the waiter image by digest produced an invalid reference like `registry/repo:sha256:...`.
aroberts87
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The allowlist waiter image helper hardcoded a
:separator between repository and tag, so pinning the waiter image by digest produced an invalid reference likequay.io/sysdig/kubectl:sha256:....This PR mirrors the existing
host/cluster/host_windowstag_separatorpattern: whengke_autopilot.allowlist_waiter.image.tagstarts withsha256:, the helper emits@instead of:, producing a valid digest reference (quay.io/sysdig/kubectl@sha256:...). Regular tags continue to render with:and the defaultvalues.yamlis unchanged.Checklist