Skip to content

Internal(Docs): Update doc links#2207

Merged
mavimo merged 12 commits intomainfrom
doclinks
Apr 8, 2025
Merged

Internal(Docs): Update doc links#2207
mavimo merged 12 commits intomainfrom
doclinks

Conversation

@benpantrey
Copy link
Copy Markdown
Contributor

@benpantrey benpantrey commented Apr 1, 2025

What this PR does / why we need it:

This PR fixes some of the documentation links.

Checklist

  • Title of the PR starts with type and scope, (e.g. feat(agent,node-analyzer,sysdig-deploy):)
  • Chart Version bumped for the respective charts
  • Variables are documented in the README.md (or README.tpl in some charts)
  • Check GithubAction checks (like lint) to avoid merge-check stoppers
  • All test files are added in the tests folder of their respective chart and have a "_test" suffix

Signed-off-by: benpantrey <[email protected]>
@benpantrey benpantrey requested review from a team as code owners April 1, 2025 12:20
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title does not comply with regex: ^(\w*)(?:\(([\w\$\.\,\-\*\s]*)\))?\:\s?(.*)$!
Check PR guidelines at https://github.com/sysdiglabs/charts/blob/main/README.md#pull-requests

@benpantrey benpantrey changed the title Fix Doc Links chore(doc links) Apr 1, 2025
@benpantrey benpantrey changed the title chore(doc links) docs(agent): Update doc links Apr 1, 2025
@github-actions github-actions Bot dismissed their stale review April 1, 2025 12:22

All good!

Signed-off-by: benpantrey <[email protected]>
Comment thread charts/harbor-scanner-sysdig-secure/values.yaml Outdated
Comment thread charts/harbor-scanner-sysdig-secure/values.yaml Outdated
@benpantrey benpantrey requested a review from mavimo April 1, 2025 14:32
Signed-off-by: benpantrey <[email protected]>
Comment thread charts/sysdig/values.yaml Outdated
Comment thread charts/sysdig/values.yaml Outdated
Comment thread charts/agent/values.yaml Outdated
Comment thread charts/agent/values.yaml Outdated
@monica-m-ps monica-m-ps changed the title docs(agent): Update doc links internal(agent): Update doc links Apr 2, 2025
@monica-m-ps monica-m-ps changed the title internal(agent): Update doc links Internal(Docs): Update doc links Apr 2, 2025
@monica-m-ps monica-m-ps marked this pull request as draft April 2, 2025 10:24
@monica-m-ps
Copy link
Copy Markdown
Collaborator

Converting to draft. Will resolve the linting errors later today

@monica-m-ps
Copy link
Copy Markdown
Collaborator

@mavimo: The build fails due to the chart version. Should we wait for it to be fixed in another PR?

Error: failed linting charts: failed processing charts
------------------------------------------------------------------------------------------------------------------------
 ✖︎ registry-scanner => (version: "1.7.0", path: "charts/registry-scanner") > chart version not ok. Needs a version bump! 
 ✖︎ sysdig => (version: "1.16.25", path: "charts/sysdig") > chart version not ok. Needs a version bump! 
 ✖︎ agent => (version: "1.36.4", path: "charts/agent") > chart version not ok. Needs a version bump! 

@monica-m-ps monica-m-ps marked this pull request as ready for review April 7, 2025 12:19
@mavimo mavimo merged commit 620f831 into main Apr 8, 2025
4 checks passed
@mavimo mavimo deleted the doclinks branch April 8, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants