Introduce ProductFilterInterface::getChannel to allow further extension#77
Open
adrienlucas wants to merge 1 commit into
Open
Introduce ProductFilterInterface::getChannel to allow further extension#77adrienlucas wants to merge 1 commit into
adrienlucas wants to merge 1 commit into
Conversation
Contributor
Author
|
Not sure why the Behat tests are failing... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the introduction of
\Synolia\SyliusAkeneoPlugin\Filter\ProductFilterInterface, I replaced the dependency between theProductFiltersRulesrepository and the twoCreateSimpleProductEntitiesTaskandCreateConfigurableProductEntitiesTaskby a dependency onProductFilterInterface.In my case, it allows to reuse those tasks without having to fake the repository.
NB : I was tempted to move the initialization of
$this->scopein the constructor of the tasks.. let me know if you find it a good idea !