Adoption of Final Qualifier in SymPy Classes#5
Open
sylee957 wants to merge 1 commit intosympy:mainfrom
Open
Conversation
Member
|
Is this proposal to request a general permission to use the |
Member
|
Is there a way to override the final decorator if you know what you are doing? |
Member
Author
|
you can always silence the type checker |
Contributor
The decorator has no runtime effect. You can still subclass a class that is marked as final but editors, typecheckers etc would warn about it. If someone would like to do it anyway but wants to use e.g. mypy then they would need to add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think that this may need separate SymPEP because it is highly relevant with
#4,
but this was originally asked for,
and I'm trying to add this because we may align with Python PEPs one-to-one.