Improve --root command on corner case#248
Open
vmartinv wants to merge 1 commit intosylvainhalle:masterfrom
Open
Improve --root command on corner case#248vmartinv wants to merge 1 commit intosylvainhalle:masterfrom
vmartinv wants to merge 1 commit intosylvainhalle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #242 I mentioned that there's a corner case not handled correctly (using both
--rootand%!TEX rootat the same time). This PR fixes and adds a test for that.--rootwill take precedence.The fix moves more of the path resolving logic from Main into LatexCleaner. Note that now Main doesn't have to worry about root paths at all.