Open
Conversation
Forks were reverting their writes directly after initial execution, and subsequent derived sets were also only updating batch_values - but that's not catching all cases. The source the async derived writes to once something has resolved to for example wasn't handled by this. Therefore this PR tweaks the logic such that we never write to `.v` in forks. I'm also wondering if we need to compare against `batch_values` inside `equals` when in a fork, but since no tests fail I only added a TODO comment.
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forks were reverting their writes directly after initial execution, and subsequent derived sets were also only updating batch_values - but that's not catching all cases. The source the async derived writes to once something has resolved to for example wasn't handled by this.
Therefore this PR tweaks the logic such that we never write to
.vin forks.I'm also wondering if we need to compare against
batch_valuesinsideequalswhen in a fork, but since no tests fail I only added a TODO comment.