Skip to content

Improve quick note editor interactions & fix filter chips responsiveness#964

Merged
ved015 merged 12 commits into
mainfrom
ishaan/dev2
May 21, 2026
Merged

Improve quick note editor interactions & fix filter chips responsiveness#964
ved015 merged 12 commits into
mainfrom
ishaan/dev2

Conversation

@ishaanxgupta
Copy link
Copy Markdown
Contributor

@ishaanxgupta ishaanxgupta commented May 18, 2026

On phone, the filter chips now get their own horizontally scrollable row, so All, Notes, Tweets, Web Pages, and any future connection chips can fit without squeezing. The Grid / Timeline segmented control stays grouped on the next row and aligned to the right.

The QuickNoteCard now uses the same TipTap TextEditor as the full-screen note, so typing / should show the slash-command options like headings. It also expands from 120px to 188px when focused or when it has draft content, then collapses again on blur if empty.

I also updated TextEditor so it can be used inline safely: it now supports editable={false} while saving, and it syncs external content resets without constantly resetting the editor while typing.

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 18, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
supermemory-mcp 9fadff1 May 21 2026, 03:57 PM

@cloudflare-workers-and-pages
Copy link
Copy Markdown

cloudflare-workers-and-pages Bot commented May 18, 2026

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
supermemory-app 9fadff1 Commit Preview URL

Branch Preview URL
May 21 2026, 03:58 PM

@ishaanxgupta ishaanxgupta changed the title fix filter chips responsiveness Improve quick note editor interactions & fix filter chips responsiveness May 18, 2026
@ishaanxgupta ishaanxgupta marked this pull request as ready for review May 20, 2026 09:20
@graphite-app graphite-app Bot requested a review from Dhravya May 20, 2026 09:20
@claude
Copy link
Copy Markdown

claude Bot commented May 20, 2026

Claude finished @ved015's task in 1m 3s —— View job


Re-review Complete

  • Check if layout shift issue was fixed
  • Review latest changes
  • Submit updated review

All three issues from @vorflux's review have been addressed:

Issue Status
Stale draft on Cmd+Enter ✅ Fixed
Fragile equality guard in TextEditor ✅ Fixed
Layout shift on desktop expand ✅ Fixed

Score: 10/10 — This looks good to ship.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Replaces the QuickNoteCard textarea with the TipTap TextEditor for consistent editing experience (including slash commands), adds expand/collapse behavior based on focus and content, and makes filter chips horizontally scrollable on mobile.

Issues found: None — this looks good to ship.

The implementation is solid:

  • The draftRef pattern in quick-note-card.tsx correctly ensures the submit callback always has the latest draft value without stale closure issues
  • The content sync effect in text-editor/index.tsx properly compares serialized content to avoid resetting the editor while the user is typing
  • The editable prop is correctly synced via setEditable() effect
  • Focus/blur handlers for expand/collapse behavior properly check e.currentTarget.contains(e.relatedTarget) to prevent collapsing on internal focus changes
  • The CSS changes for responsive filter chips are straightforward layout adjustments

Score: 10/10

ishaanxgupta and others added 6 commits May 20, 2026 22:59
The editorHeight variable was defined but never used. Now it's applied
to the TextEditor container div. Also fixed formatting to match biome
expectations.

Co-Authored-By: Claude Opus 4.5 <[email protected]>
Copy link
Copy Markdown
Contributor

@vorflux vorflux Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks solid. Three issues to address before merge.


Review with Vorflux

Comment thread apps/web/components/quick-note-card.tsx Outdated
Comment thread apps/web/components/text-editor/index.tsx Outdated
Comment thread apps/web/components/quick-note-card.tsx
@ved015
Copy link
Copy Markdown
Member

ved015 commented May 21, 2026

@ishaanxgupta pls have a look at the suggestions

@vorflux
Copy link
Copy Markdown
Contributor

vorflux Bot commented May 21, 2026

@ishaangupta-yk FYI — review comments above from Vedant. Three issues flagged: stale draft on Cmd+Enter, fragile content equality guard in TextEditor, and a layout jump on desktop expand. Let me know if you have questions.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Re-review after fix vorflux comments commit addressing the three issues flagged previously.

Issues addressed:

  • Stale draft on Cmd+Enter — Fixed. TextEditor.onSubmit now receives the current markdown directly from the editor (getEditorMarkdown(currentEditor)) instead of reading from a potentially stale ref.
  • Fragile equality guard — Fixed. The new implementation uses lastAppliedContentRef and lastEmittedContentRef to track content state, preventing the editor from resetting on every keystroke when its own emissions come back.
  • Layout shift on desktop expand — Still present. The sm:w-full class is missing from the expanded state, so the outer wrapper shrinks to 640px on desktop causing a grid layout jump.

Score: 9/10 — One small fix remaining.

Comment thread apps/web/components/quick-note-card.tsx Outdated
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview: Replaces the QuickNoteCard textarea with the TipTap TextEditor for consistent editing experience (including slash commands), adds expand/collapse behavior based on focus and content, and makes filter chips horizontally scrollable on mobile.

Issues found: None — all three issues from the previous review have been addressed.

  • Stale draft on Cmd+Enter — Fixed. TextEditor.onSubmit now receives the current markdown directly from the editor via getEditorMarkdown(currentEditor).
  • Fragile equality guard — Fixed. The new implementation uses lastAppliedContentRef and lastEmittedContentRef to track content state, preventing the editor from resetting on every keystroke.
  • Layout shift on desktop expand — Fixed. The sm:w-full class is now present in the expanded state, keeping the outer container at full width on desktop.

Score: 10/10

@ved015 ved015 merged commit 7f6b28a into main May 21, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants