Improve quick note editor interactions & fix filter chips responsiveness#964
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-mcp | 9fadff1 | May 21 2026, 03:57 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
supermemory-app | 9fadff1 | Commit Preview URL Branch Preview URL |
May 21 2026, 03:58 PM |
|
Claude finished @ved015's task in 1m 3s —— View job Re-review Complete
All three issues from @vorflux's review have been addressed:
Score: 10/10 — This looks good to ship. |
There was a problem hiding this comment.
Overview: Replaces the QuickNoteCard textarea with the TipTap TextEditor for consistent editing experience (including slash commands), adds expand/collapse behavior based on focus and content, and makes filter chips horizontally scrollable on mobile.
Issues found: None — this looks good to ship.
The implementation is solid:
- The
draftRefpattern inquick-note-card.tsxcorrectly ensures the submit callback always has the latest draft value without stale closure issues - The content sync effect in
text-editor/index.tsxproperly compares serialized content to avoid resetting the editor while the user is typing - The
editableprop is correctly synced viasetEditable()effect - Focus/blur handlers for expand/collapse behavior properly check
e.currentTarget.contains(e.relatedTarget)to prevent collapsing on internal focus changes - The CSS changes for responsive filter chips are straightforward layout adjustments
Score: 10/10
Co-Authored-By: Claude Opus 4.5 <[email protected]>
The editorHeight variable was defined but never used. Now it's applied to the TextEditor container div. Also fixed formatting to match biome expectations. Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
@ishaanxgupta pls have a look at the suggestions |
|
@ishaangupta-yk FYI — review comments above from Vedant. Three issues flagged: stale draft on Cmd+Enter, fragile content equality guard in TextEditor, and a layout jump on desktop expand. Let me know if you have questions. |
Co-Authored-By: Claude Opus 4.5 <[email protected]>
There was a problem hiding this comment.
Overview: Re-review after fix vorflux comments commit addressing the three issues flagged previously.
Issues addressed:
- ✅ Stale draft on Cmd+Enter — Fixed.
TextEditor.onSubmitnow receives the current markdown directly from the editor (getEditorMarkdown(currentEditor)) instead of reading from a potentially stale ref. - ✅ Fragile equality guard — Fixed. The new implementation uses
lastAppliedContentRefandlastEmittedContentRefto track content state, preventing the editor from resetting on every keystroke when its own emissions come back. - ❌ Layout shift on desktop expand — Still present. The
sm:w-fullclass is missing from the expanded state, so the outer wrapper shrinks to 640px on desktop causing a grid layout jump.
Score: 9/10 — One small fix remaining.
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Overview: Replaces the QuickNoteCard textarea with the TipTap TextEditor for consistent editing experience (including slash commands), adds expand/collapse behavior based on focus and content, and makes filter chips horizontally scrollable on mobile.
Issues found: None — all three issues from the previous review have been addressed.
- ✅ Stale draft on Cmd+Enter — Fixed.
TextEditor.onSubmitnow receives the current markdown directly from the editor viagetEditorMarkdown(currentEditor). - ✅ Fragile equality guard — Fixed. The new implementation uses
lastAppliedContentRefandlastEmittedContentRefto track content state, preventing the editor from resetting on every keystroke. - ✅ Layout shift on desktop expand — Fixed. The
sm:w-fullclass is now present in the expanded state, keeping the outer container at full width on desktop.
Score: 10/10
Co-Authored-By: Claude Opus 4.5 <[email protected]>
On phone, the filter chips now get their own horizontally scrollable row, so All, Notes, Tweets, Web Pages, and any future connection chips can fit without squeezing. The Grid / Timeline segmented control stays grouped on the next row and aligned to the right.
The QuickNoteCard now uses the same TipTap TextEditor as the full-screen note, so typing / should show the slash-command options like headings. It also expands from 120px to 188px when focused or when it has draft content, then collapses again on blur if empty.
I also updated TextEditor so it can be used inline safely: it now supports editable={false} while saving, and it syncs external content resets without constantly resetting the editor while typing.