add stable_hashrate flag to channels_sv2::server#2152
Open
plebhash wants to merge 1 commit into
Open
Conversation
plebhash
force-pushed
the
2026-05-12-stable-hashrate-bool
branch
from
793b918 to
782ef9a
Compare
plebhash
changed the title
stable_hashrate flag to channels_sv2stable_hashrate flag to channels_sv2::server
plebhash
force-pushed
the
2026-05-12-stable-hashrate-bool
branch
from
782ef9a to
9edcc5f
Compare
GitGab19
approved these changes
May 13, 2026
GitGab19
requested changes
May 13, 2026
Member
GitGab19
left a comment
GitGab19
left a comment
There was a problem hiding this comment.
I just noticed we need to add the new stable_hashrate field in the channels docs.
plebhash
force-pushed
the
2026-05-12-stable-hashrate-bool
branch
from
9edcc5f to
b703546
Compare
plebhash
force-pushed
the
2026-05-12-stable-hashrate-bool
branch
from
b703546 to
3da394f
Compare
GitGab19
approved these changes
May 14, 2026
Shourya742
reviewed
May 14, 2026
Member
Shourya742
left a comment
Shourya742
left a comment
There was a problem hiding this comment.
I have some other thoughts on the implementation here. I don't think stable_hashrate is the right abstraction to represent vardiff stability. I think associating an Instant with the nominal hashrate would be a better way to convey the idea. For example, it could show how long the current hashrate has remained stable, something like “stable since xx minutes.”
It should also be very easy to track through the update_channel method, where we already update the nominal hashrate, without requiring any additional changes related to stability tracking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2143
companion stratum-mining/sv2-apps#496