Fix Python 3.11 test failures and mask-free CI failure reporting#34
Merged
Fix Python 3.11 test failures and mask-free CI failure reporting#34
Conversation
…st-coverage # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…lasses, formatting, tests modules Co-authored-by: gb119 <[email protected]> Agent-Logs-Url: https://github.com/stonerlab/Stoner-PythonCode/sessions/75f784fd-7c8b-4c8d-8e27-ca55f951f845
Copilot
AI
changed the title
[WIP] Add additional tests to increase coverage on stable branch
Increase test coverage on stable branch
Mar 20, 2026
Test Results 4 files + 1 4 suites +1 22m 55s ⏱️ + 5m 3s For more details on these failures and errors, see this check. Results for commit 114151a. ± Comparison against base commit 6cb282d. |
Copilot
AI
changed the title
Increase test coverage on stable branch
Fix Python 3.11 test failures and mask-free CI failure reporting
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs caused Python 3.11 CI runs to silently report 158 test failures as success.
super()in list comprehension — Python 3.11 incompatibilityIn Python ≤ 3.11, list comprehensions run in a nested function scope. Bare
super()relies on a__class__cell that isn't propagated into that scope, raisingTypeError: super(type, obj): obj must be an instance or subtype of type. PEP 709 (Python 3.12) inlined comprehensions, which is why this only breaks on 3.11.Stoner/core/base.py—TypeHintedDict.__getitem__:CI exit-code masking
The "Test with xvfb" step runs under
bash -l {0}(no-e). Whenpytestexits non-zero,coverage xmlstill runs and returns 0, so the step — and the whole job — reports success despite test failures..github/workflows/run-tests-action.yaml:⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.