Make ImageArray a descriptor to enforce ImageFile.image type invariant#33
Merged
Make ImageArray a descriptor to enforce ImageFile.image type invariant#33
Conversation
…earray-as-descriptor
Co-authored-by: gb119 <[email protected]> Agent-Logs-Url: https://github.com/stonerlab/Stoner-PythonCode/sessions/d081e12b-a908-4505-889c-138c772d5920
Copilot
AI
changed the title
[WIP] Update ImageArray to be a descriptor for ImageFile
Make ImageArray a descriptor to enforce ImageFile.image type invariant
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ImageFile.imagewas a plain@propertywith no type enforcement at the class level. This mirrors the DataArray descriptor pattern (PR #32) toImageArray/ImageFile.Changes
ImageArray— descriptor protocol: Added__set_name__,__get__,__set__so anyImageArrayinstance can serve as a data descriptor. The setter preserves filename/metadata from the previous image and handles the in-place stack-update path.ImageFile— replace@propertywith class-level descriptor:KerrImageFile— fix subclass override:@ImageFile.image.getter/@ImageFile.image.setterareproperty-only patterns that broke onceimagebecame a descriptor. Replaced with a self-contained@property/@image.setterpair that overrides the descriptor in the subclass.Tests: Added
test_image_descriptorcovering class-level type assertion, numpy→ImageArraycoercion, metadata preservation, and filename preservation across image replacement.⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.