bump gloas spec to alpha.4#8168

Merged

tersec merged 14 commits intounstablefrom

Apr 4, 2026

Contributor

Tomi-3-0 commented Mar 25, 2026

No description provided.

github-actions bot commented Mar 25, 2026 •

edited

Loading

Unit Test Results

      12 files ±    0   2 504 suites +16 54m 48s ⏱️ + 5m 50s
13 053 tests +  75 12 506 ✔️ +  75 547 💤 ±0 0 ❌ ±0
66 068 runs +456 65 358 ✔️ +456 710 💤 ±0 0 ❌ ±0

Results for commit 18cbbf4. ± Comparison against base commit 4d0196c.

♻️ This comment has been updated with latest results.

Tomi-3-0 changed the title ~~bump gloas spec to alpha.3~~ bump gloas spec to alpha.4

Tomi-3-0 marked this pull request as ready for review

March 30, 2026 20:59

Contributor

tersec commented Mar 30, 2026

Merge conflict in the submodule vendor/nim-ssz-serialization.

Contributor

tersec commented Mar 30, 2026

Run excluded_files="config.yaml|config.nims|beacon_chain.nimble|Makefile|Product.wxs"
The following files do not have an up-to-date copyright year:
- tests/consensus_spec/fulu/test_fixture_ssz_consensus_objects.nim
- tests/consensus_spec/gloas/test_fixture_state_transition_epoch.nim

Tomi-3-0 force-pushed the Tg4 branch 3 times, most recently from eb4e0be to 058dfc4 Compare

March 30, 2026 22:53

tersec reviewed

View reviewed changes

beacon_chain/spec/beaconstate.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/state_transition_block.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/validator.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/state_transition_block.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/state_transition_block.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/state_transition_block.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/state_transition_block.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/state_transition_epoch.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

tests/consensus_spec/gloas/test_fixture_operations.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/beaconstate.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/beaconstate.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/beaconstate.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/beaconstate.nim Outdated Show resolved Hide resolved

Tomi-3-0 force-pushed the Tg4 branch from b3c75d8 to d6a67a2 Compare

March 31, 2026 14:35

ahshum reviewed

View reviewed changes

beacon_chain/gossip_processing/gossip_validation.nim Outdated Show resolved Hide resolved

beacon_chain/gossip_processing/gossip_validation.nim Outdated Show resolved Hide resolved

beacon_chain/spec/state_transition_block.nim Outdated Show resolved Hide resolved

tests/consensus_spec/gloas/test_fixture_operations.nim Outdated Show resolved Hide resolved

Tomi-3-0 requested review from ahshum and tersec

March 31, 2026 21:06

ahshum reviewed

View reviewed changes

beacon_chain/gossip_processing/gossip_validation.nim Show resolved Hide resolved

beacon_chain/gossip_processing/gossip_validation.nim Show resolved Hide resolved

Tomi-3-0 force-pushed the Tg4 branch 3 times, most recently from d767585 to 12d29e1 Compare

April 1, 2026 13:38

ahshum reviewed

View reviewed changes

beacon_chain/consensus_object_pools/attestation_pool.nim Outdated Show resolved Hide resolved

beacon_chain/gossip_processing/gossip_validation.nim Show resolved Hide resolved

beacon_chain/nimbus_beacon_node.nim Outdated Show resolved Hide resolved

Tomi-3-0 added 4 commits

April 2, 2026 17:08


          review

61a00bd


          check envelope quarantine for attestation validation

67a43ab


          refactor: pass env quarantine into attestatn validation

3bc1cc7


          replace doAssert with return

d83a949

Tomi-3-0 force-pushed the Tg4 branch from 11fada7 to f87738c Compare

April 2, 2026 16:09

tersec reviewed

View reviewed changes

beacon_chain/spec/state_transition_block.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/state_transition_epoch.nim Outdated

+                  for idx in compute_ptc(state, slot, cache):
+                    ptcArray[i] = uint64(idx)
+                    inc i
+                  state.ptc_window.mitem(base_index + slot_offset) = ptcArray

Contributor

tersec Apr 3, 2026

This currently does an extra copy, i.e. it constructs each subset HashArray of the PTC lookahead then copies that. But it could fill in the target directly.

The challenge is to avoid constant hash recomputation, but that can be done manually.

tersec reviewed

View reviewed changes

beacon_chain/spec/beaconstate.nim Outdated

+                    for idx in compute_ptc(state, slot, cache):
+                      ptcArray[i] = uint64(idx)
+                      inc i
+                    state.ptc_window.mitem(base_index + slot_offset) = ptcArray

Contributor

tersec Apr 3, 2026

See:

https://github.com/status-im/nimbus-eth2/pull/8168/changes#r3031997501

regarding how it does extra copies/allocations.

tersec reviewed

View reviewed changes

beacon_chain/spec/beaconstate.nim Outdated Show resolved Hide resolved


          review

1d10dd4

Tomi-3-0 force-pushed the Tg4 branch from f87738c to 1d10dd4 Compare

April 3, 2026 11:38

tersec reviewed

View reviewed changes

beacon_chain/spec/state_transition_block.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/beaconstate.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/state_transition_block.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/beaconstate.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

tests/consensus_spec/gloas/test_fixture_operations.nim Outdated Show resolved Hide resolved


          address reviews

cd5f7ee

Tomi-3-0 force-pushed the Tg4 branch from d86af12 to cd5f7ee Compare

April 4, 2026 13:59

tersec reviewed

View reviewed changes

beacon_chain/spec/beaconstate.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/beaconstate.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/beaconstate.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/state_transition_block.nim Outdated Show resolved Hide resolved


          reviews

18cbbf4

Tomi-3-0 force-pushed the Tg4 branch from 406a540 to 18cbbf4 Compare

April 4, 2026 15:47

tersec reviewed

View reviewed changes

beacon_chain/spec/beaconstate.nim Outdated Show resolved Hide resolved

tersec reviewed

View reviewed changes

beacon_chain/spec/state_transition_epoch.nim Outdated Show resolved Hide resolved


          review: call clearCache once per slot_offset entry

aa6c908

tersec enabled auto-merge (squash)

April 4, 2026 19:13

tersec merged commit d1493b4 into unstable

10 checks passed

tersec deleted the Tg4 branch

April 4, 2026 20:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet