Conversation
Tomi-3-0
changed the title
Tomi-3-0
force-pushed
the
gloas/fork-choice
branch
from
becbf0b to
2c3a6f5
Compare
Tomi-3-0
force-pushed
the
gloas/fork-choice
branch
from
dca9a04 to
33613d2
Compare
tests/test_fork_choice_gloas.nim
Outdated
There was a problem hiding this comment.
Do existing fork Gloas choice tests, the ones in {mainnet,minimal}/gloas/fork_choice and executed by https://github.com/status-im/nimbus-eth2/blob/unstable/tests/consensus_spec/test_fixture_fork_choice.nim cover any of this?
There was a problem hiding this comment.
They do cover the core fork choice implementation. This is an attempt to cover implementation-specific and some basic sanity checks. I plan to progressively remove the redundant tests.
| return true | ||
| false | ||
|
|
||
| func should_extend_payload*( |
There was a problem hiding this comment.
| if vote: | ||
| inc vote_count | ||
|
|
||
| if vote_count.uint64 > PAYLOAD_TIMELY_THRESHOLD: |
There was a problem hiding this comment.
Would be better to declare vote_count as a uint64 to begin with than convert each time. There's no strong reason it has to be int. e.g., var vote_count: uint64 (i.e. 0 initialization is by default) or var vote_count = 0'u64, equivalently.
| proposer_boost_root = shortLog(proposer_root) | ||
| false | ||
|
|
||
| func get_payload_status_tiebreaker*( |
There was a problem hiding this comment.
Tomi-3-0
force-pushed
the
gloas/fork-choice
branch
from
65397ac to
ddb93b3
Compare
Tomi-3-0
force-pushed
the
gloas/fork-choice
branch
from
08ec020 to
957aed2
Compare
Tomi-3-0
force-pushed
the
gloas/fork-choice
branch
from
de87460 to
60058ef
Compare
3 participants
No description provided.