Open
Conversation
arnetheduck
force-pushed
the
threadchannel
branch
from
5c637d3 to
f1fcc75
Compare
arnetheduck
force-pushed
the
threadchannel
branch
2 times, most recently
from
121da27 to
15e3039
Compare
arnetheduck
force-pushed
the
threadchannel
branch
from
15e3039 to
dd14744
Compare
arnetheduck
force-pushed
the
threadchannel
branch
2 times, most recently
from
b8d0695 to
eadb4c3
Compare
arnetheduck
force-pushed
the
threadchannel
branch
3 times, most recently
from
d377588 to
75f528d
Compare
Instead of using a socket (and having to open a fake connection between EL and CL), this pr switches to status-im/nim-json-rpc#254 for internal communication. Eventually, one could make this more efficient by skipping the JSON step, but like this, we at least no longer have to open an Engine API port which makes this setup more secure and easy to deploy (fewer open ports). There's also fewer potential errors to contend with and payloads don't have to travel across the OS buffers and instead stay internal to the process.
arnetheduck
force-pushed
the
threadchannel
branch
from
75f528d to
30a028b
Compare
Member
Jenkins BuildsClick to see older builds (14)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using a socket (and having to open a fake connection between EL and CL), this pr switches to
status-im/nim-json-rpc#254 for internal communication.
Eventually, one could make this more efficient by skipping the JSON step, but like this, we at least no longer have to open an Engine API port which makes this setup more secure and easy to deploy (fewer open ports).
There's also fewer potential errors to contend with and payloads don't have to travel across the OS buffers and instead stay internal to the process.