Skip to content

Add unicode conversion pre-parsing for sparql#40

Draft
joshhk72 wants to merge 5 commits intomasterfrom
feature/unicode-conversion
Draft

Add unicode conversion pre-parsing for sparql#40
joshhk72 wants to merge 5 commits intomasterfrom
feature/unicode-conversion

Conversation

@joshhk72
Copy link
Copy Markdown
Contributor

@joshhk72 joshhk72 commented Sep 21, 2020 •
edited
Loading

  • Works by keeping track of the indices of replaced codepoints

Notes:

  • Is it worth making this work with suggestions as well? (should the language server provide suggestions for S\u0045LE as it would for SELE (being completed to SELECT for SPARQL).

@joshhk72 joshhk72 requested a review from anneeb September 21, 2020 20:31
@joshhk72 joshhk72 marked this pull request as ready for review September 23, 2020 19:16
@joshhk72 joshhk72 requested review from jmrog and removed request for anneeb September 28, 2020 15:18
anneeb
anneeb reviewed Sep 28, 2020
View reviewed changes
Comment thread packages/stardog-language-utils/src/namespaceUtils.ts Outdated
anneeb
anneeb reviewed Sep 29, 2020
View reviewed changes
Comment thread packages/sparql-language-server/src/SparqlLanguageServer.ts Outdated
@joshhk72 joshhk72 requested a review from anneeb September 30, 2020 15:23
@anneeb
Copy link
Copy Markdown
Contributor

anneeb commented Sep 30, 2020

Converting this back to a draft for now to reflect that we want to wait for server support before releasing

@anneeb anneeb marked this pull request as draft September 30, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmrog jmrog Awaiting requested review from jmrog

@anneeb anneeb Awaiting requested review from anneeb

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshhk72 @anneeb