[WIP] fix: parse spec using ref-parser bundle() to handle circular refs#8
Draft
[WIP] fix: parse spec using ref-parser bundle() to handle circular refs#8
Conversation
RobertCraigie
approved these changes
Jan 16, 2025
Member
RobertCraigie
left a comment
There was a problem hiding this comment.
I don't know too much about the internals of the ref parser but your logic seems sound to me.
Would recommend testing this against our codegen before merging, either by just running things locally or getting it setup in CI
Member
Author
|
I'm seeing the following issue on some endpoints: Not clear why :s I will wait before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://apitools.dev/json-schema-ref-parser/docs/#circular-refs.
That fixes the circular ref hangs we've seen with https://github.com/stainless-sdks/wand-demo-python/actions/runs/12808284439/job/35710674735 timing out after 6h.
Why I think that change is safe:
decycle(dereference(specFile)), resulting in a loop. My change isdecycle(bundle(specFile)). Heredecycleis from @stoplight/json.But I would be happy to get a review here.