Typescript Migration: Tests#1095
Open
theodorehreuter wants to merge 45 commits intomainfrom
Open
Conversation
…nner not identifying the error typescript file and finding temporary workaround during migration.
…ts. Confirmed using s3-utils.ts passes all tests
…ut input object in test to be a more complete StacItem to pass an expected logic gate
…adding types as necessary
… feat: some of the LLM converted tests
…910/type-test-finalize-typescript-migration
…910/type-test-finalize-typescript-migration
theodorehreuter
changed the base branch from
tr/drop-909/type-ingest-and-lambda-entry
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Proposed Changes:
Converting the tests to Typescript. This was done with having Claude doing a major first pass and then reviewing myself, after doing all the other work of building and honing types through the other PRs of the typescript migration, and then let claude rip on the tests.
This is the final PR that completes the typescript migration of stac-server.
A significant amount of the diff is minor linting changes required by typescript, though some changes were also necessitated by changing
noImplicitAny: falsetotruewhich turned up some additional typescript errors around the repo that required some minor changes, particularly in the database.ts. Keeping in line with the rest of the migration there are no changes to business logic.PR Checklist: