Skip to content

feat(ext): Solar System extension "ssys"#1711

Open
s-boomi wants to merge 6 commits intostac-utils:mainfrom
s-boomi:feature/ssys-extension
Open

feat(ext): Solar System extension "ssys"#1711
s-boomi wants to merge 6 commits intostac-utils:mainfrom
s-boomi:feature/ssys-extension

Conversation

@s-boomi
Copy link
Copy Markdown

@s-boomi s-boomi commented Apr 24, 2026

Related Issue(s):

  • (None)

Description:

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage
  • This PR's title is formatted per conventional commits

@gadomski gadomski self-requested a review April 27, 2026 11:48
@gadomski
Copy link
Copy Markdown
Member

gadomski commented May 7, 2026

@s-boomi honest question, to create this PR did you prompt a code-generating system with something like "Take https://github.com/stac-extensions/ssys/ and make a pystac extension for it?"

This isn't meant as a negative thing, this is just trying to understand the creation process. If it's this simple to create a PySTAC extension like this, I'm not sure it's worth merging it with main ... we could just give people prompts to make their own extension as-needed, or host a LLM-generated one somewhere else outside of the PySTAC codebase?

@s-boomi
Copy link
Copy Markdown
Author

s-boomi commented May 7, 2026

@s-boomi honest question, to create this PR did you prompt a code-generating system with something like "Take https://github.com/stac-extensions/ssys/ and make a pystac extension for it?"

This isn't meant as a negative thing, this is just trying to understand the creation process. If it's this simple to create a PySTAC extension like this, I'm not sure it's worth merging it with main ... we could just give people prompts to make their own extension as-needed, or host a LLM-generated one somewhere else outside of the PySTAC codebase?

I simply followed other examples already present in the extension folder. Besides, I already had a custom ssys extension beforehand for my other project. From then, aside from a couple of tests, it was mostly copying and replacing. The only instances I made use of LLMs in that case is to sniff potential checks, but for the most part, it was copypasting from other extensions.

I figured out adding the ssys extension to the main package was beneficiary for people working in planetary sciences like me. In my honest opinion, I think extensions should be placed in another repository altogether, much like pydantic_settings was for pydantic, and be curated by the community, following a set of specific guidelines.

@gadomski
Copy link
Copy Markdown
Member

gadomski commented May 7, 2026

Cool, thanks for the explanation, I appreciate it. We see a lot of incoming code (in this repository and in others) that has been mostly/completely generated, and those tend to be harder to review b/c they have subtle errors and problems. Your context on your PR helps me "tune" my review, so thanks! 🙇🏼

In my honest opinion, I think extensions should be placed in another repository altogether, much like pydantic_settings was for pydantic, and be curated by the community, following a set of specific guidelines.

We're starting to move this direction, as of #1650. We had a similar problem in https://github.com/stac-utils/stactools/ and ended up settling on a whole new Github organization, https://github.com/stactools-packages/, to house the dataset-specifc repositories. I don't think we'll go that direction for pystac extensions; for now, separate-packages-but-same-repo seems like a decent compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants