fix: V2 summaries#1710
Merged
gadomski merged 4 commits intostac-utils:v2from May 5, 2026
Merged
Conversation
jsignell
commented
Apr 23, 2026
| VERSION="1.5.0" | ||
| SRC="https://cdn.jsdelivr.net/npm/@radiantearth/stac-fields@$VERSION/fields-normalized.json" | ||
| HERE=$(dirname "$0") | ||
| DEST=$(dirname "$HERE")/pystac/static/fields-normalized.json |
Member
Author
There was a problem hiding this comment.
@tylanderson if you do mkdir on this DEST and then run ./scripts/pull-static with this diff you'll get your static file populated.
jsignell
commented
Apr 23, 2026
| @final | ||
| class Properties(Basics, DateTime, Licensing, Providers, Instrument): | ||
| class Properties( | ||
| MutableMapping[str, Any], Basics, DateTime, Licensing, Providers, Instrument |
Member
Author
There was a problem hiding this comment.
This makes it so properties can pretty much be treated like a dict. We might want to do this in some other places in the codebase.
Member
Author
|
Ok so I was worried about changing |
Member
Author
|
Ok I didn't quite get the typing working, but I did rewrite |
Draft
Member
Author
|
Ok I have the typing working for summaries. |
gadomski
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't quite have typing figured out onSummariesyet, but wanted to get this up.This one is ready to go