Skip to content

V2 catalog test updates#1702

Draft
ircwaves wants to merge 6 commits intostac-utils:v2from
ircwaves:v2-catalog
Draft

V2 catalog test updates#1702
ircwaves wants to merge 6 commits intostac-utils:v2from
ircwaves:v2-catalog

Conversation

@ircwaves
Copy link
Copy Markdown
Member

Related Issue(s):

Description:

  • TBD

PR Checklist:

  • Pre-commit hooks pass (run pre-commit run --all-files)
  • Tests pass (run pytest)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage
  • This PR's title is formatted per conventional commits

@ircwaves ircwaves mentioned this pull request Apr 22, 2026
23 tasks
@ircwaves ircwaves force-pushed the v2-catalog branch 3 times, most recently from e2e2a97 to e35775f Compare April 24, 2026 19:36
Comment thread tests/v1/test_catalog.py Outdated
assert asset.title != "NEW TITLE"
assert found

@pytest.mark.xfail(reason=".media_type replaced with .type")
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed.

Comment thread tests/v1/test_catalog.py Outdated
assert found
assert not_found

@pytest.mark.xfail(reason=".media_type replaced with .type")
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

Comment thread tests/v1/test_catalog.py
with pytest.raises(pystac.STACValidationError):
cat2.validate_all()

@pytest.mark.xfail(reason="Item.datetime property has no setter")
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restored setter method for Item.datetime

Comment thread tests/v1/test_catalog.py Outdated
assert len(all_collections) == 4
assert all(isinstance(c, pystac.Collection) for c in all_collections)

@pytest.mark.xfail(reason="Catalog.get_single_link media_type parameter removed")
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restored.

Comment thread tests/v1/test_catalog.py Outdated
@ircwaves
Copy link
Copy Markdown
Member Author

OK, I've caught this up with the v2 branch, but I don't think I've got it into a good place to merge yet. I think the xfail reasons on the tests/v1/test_catalog.py tests are a good triage of what needs to be addressed for this to be merged.

Unfortunately, I'm not going to be able to get to those for a while. I might pick this back up if no one else grabs it in the mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants