Skip to content

*Minor* conferences change#165

Open
catabush05 wants to merge 1 commit intosportsdataverse:mainfrom
catabush05:patch-1
Open

*Minor* conferences change#165
catabush05 wants to merge 1 commit intosportsdataverse:mainfrom
catabush05:patch-1

Conversation

@catabush05
Copy link
Copy Markdown

@catabush05 catabush05 commented Oct 1, 2025

There was one faulty line of code:

dplyr::select(-"subGroups") %>%

that was causing the entire espn_mbb_conferences() function and subsequently the conferences portion of the espn_mbb_teams() function to break. It was not needed, given the GET response, and removing it caused the function to work as intended. As the title implies, it is a very small change.

Summary by CodeRabbit

  • New Features
    • espn_mbb_conferences now returns the subGroups column in conference data, exposing subgroup details for each conference.
    • This expands the dataset returned to users, enabling richer filtering and analysis based on sub-conference structures.
    • Note: The output schema has changed; update any workflows or scripts that assumed the previous column set.

Removed a faulty line of code that was causing the conference function to be broken.

Signed-off-by: Catalina Bush <[email protected]>
@vercel
Copy link
Copy Markdown

vercel bot commented Oct 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hoopr Ready Ready Preview Comment Oct 1, 2025 0:33am

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 1, 2025

Walkthrough

The function espn_mbb_conferences in R/espn_mbb_data.R no longer drops the subGroups column. The returned conferences data frame now includes subGroups, altering the public output schema. No changes to control flow, parameters, or error handling.

Changes

Cohort / File(s) Summary
ESPN MBB data schema
R/espn_mbb_data.R
Retained the subGroups column in espn_mbb_conferences by removing the dplyr::select(-"subGroups") step; output schema now includes subGroups.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hop through frames where columns play,
A subGroup reappears today—
No branching paths, no errors new,
Just tidy rows with added view.
My whiskers twitch: schema’s right,
More fields to nibble—data bite! 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title Check ❓ Inconclusive The title “Minor conferences change” relies on the qualifier “Minor” and a broad reference to “conferences change” without conveying the specific update of removing the dplyr::select(-"subGroups") line, so it does not clearly summarize the key change introduced by the pull request. Please revise the title to explicitly reflect the main change, for example “Remove subGroups column drop in espn_mbb_conferences()”, so that it clearly and concisely communicates the specific update to reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ee009e and d179f33.

📒 Files selected for processing (1)
  • R/espn_mbb_data.R (0 hunks)
💤 Files with no reviewable changes (1)
  • R/espn_mbb_data.R

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant