Conversation
Removed a faulty line of code that was causing the conference function to be broken. Signed-off-by: Catalina Bush <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughThe function espn_mbb_conferences in R/espn_mbb_data.R no longer drops the subGroups column. The returned conferences data frame now includes subGroups, altering the public output schema. No changes to control flow, parameters, or error handling. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was one faulty line of code:
dplyr::select(-"subGroups") %>%that was causing the entire espn_mbb_conferences() function and subsequently the conferences portion of the espn_mbb_teams() function to break. It was not needed, given the GET response, and removing it caused the function to work as intended. As the title implies, it is a very small change.
Summary by CodeRabbit