fix: use correct singular/plural forms for source file count strings#14456
Open
jaythehardcoder wants to merge 1 commit into
Open
fix: use correct singular/plural forms for source file count strings#14456jaythehardcoder wants to merge 1 commit into
jaythehardcoder wants to merge 1 commit into
Conversation
The build_specific and build_update summary messages used hardcoded plural strings even when the count was 1, producing grammar errors like "1 source files given on command line". This fix uses conditional string selection to produce correct singular/plural forms based on the actual file count. Fixes sphinx-doc#12903
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The build status messages for
build_specificandbuild_updateuse hardcoded plural strings ("%d source files given on command line") even when the count is 1, producing grammar errors like"1 source files given on command line".Fix
Use conditional string selection so the correct singular/plural form is used based on the actual file count:
"1 source file given on command line"for a single file"%d source files given on command line"for multiple filesbuild_updatesummary stringTest Plan
test_build_specific_single_fileverifies the singular casetest_build_specific(multi-file) still passestests/test_application.pyCloses #12903