Expose graphviz stderr from successful renders#14438
Open
Mirochill wants to merge 1 commit into
Open
Conversation
Mirochill
force-pushed
the
fix-14362-graphviz-stderr
branch
from
e738d88 to
506414d
Compare
jdillard
added
the
extensions:graphviz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Surface Graphviz diagnostics that are currently lost when
dotexits successfully but writes warnings to stderr.This keeps successful renders successful, but forwards the captured stderr through Sphinx's warning channel so users can see messages such as unsupported-style warnings instead of having them silently discarded.
The change also adds a focused regression test for the successful-render-with-stderr path. While exercising the new behavior in Sphinx's own docs build, it exposed stale
p1port references in the bundled build-flow diagram; those invalid references are removed so the diagram remains warning-clean under Graphviz.References
Validation