fic(ifc): Fix for element quantities that contain nan values #458
Merged
fic(ifc): Fix for element quantities that contain nan values #458
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #458 +/- ##
=======================================
Coverage 90.61% 90.61%
=======================================
Files 138 138
Lines 6373 6373
=======================================
Hits 5775 5775
Misses 598 598 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gjedlicska
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got some alerts of a flood of 400 errors triggered by IFC uploads.
I believe this is caused by
NaNvalues being sent to the server.js and python disagree with how to serialize NaN values, so the server was handling the post requests to
/objects/:streamIdas invalid json.In this PR, for IFC values that we know may be NaN, I'm mapping them to
Nonevalues.This follows the js standard of mapping to
nullvalueThe python standard is to serialize them as a
NaNkeyword value.I've also see other serializers write a
"NaN"value instead... but felt thatnoneis easier to deal with than mixing types.