fix(speckleifc): Geometry counter not to count empty geometries#455
Merged
fix(speckleifc): Geometry counter not to count empty geometries#455
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #455 +/- ##
=======================================
Coverage 90.59% 90.59%
=======================================
Files 138 138
Lines 6379 6379
=======================================
Hits 5779 5779
Misses 600 600 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gjedlicska
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geometry counter was meant to count how many geometries were used.
This is to allow us to get an idea for how many (if any) geometries were processed, but not actually used.
However, there was flaw in the null check that was leading to us counting objects that have no geometry as a "used geometry"... this meant the "used geometry" was far exceeding the "created geometry" for models that contain a lot of elements that have no geometry.