Skip to content

fix(speckleifc): Geometry counter not to count empty geometries#455

Merged
JR-Morgan merged 2 commits intomainfrom
jrm/fix-counter
Oct 1, 2025
Merged

fix(speckleifc): Geometry counter not to count empty geometries#455
JR-Morgan merged 2 commits intomainfrom
jrm/fix-counter

Conversation

@JR-Morgan
Copy link
Copy Markdown
Member

Geometry counter was meant to count how many geometries were used.
This is to allow us to get an idea for how many (if any) geometries were processed, but not actually used.

However, there was flaw in the null check that was leading to us counting objects that have no geometry as a "used geometry"... this meant the "used geometry" was far exceeding the "created geometry" for models that contain a lot of elements that have no geometry.

@JR-Morgan JR-Morgan enabled auto-merge (squash) September 19, 2025 14:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.59%. Comparing base (0cd0c3a) to head (6a79b02).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   90.59%   90.59%           
=======================================
  Files         138      138           
  Lines        6379     6379           
=======================================
  Hits         5779     5779           
  Misses        600      600           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JR-Morgan JR-Morgan requested a review from gjedlicska October 1, 2025 10:22
@JR-Morgan JR-Morgan merged commit e4453f0 into main Oct 1, 2025
7 checks passed
@JR-Morgan JR-Morgan deleted the jrm/fix-counter branch October 1, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants