Skip to content

change istall method of digikey-api requirement to git submodule#281

Merged
T0jan merged 6 commits into
sparkmicro:mainfrom
T0jan:local_digykey_api
Mar 25, 2026
Merged

change istall method of digikey-api requirement to git submodule#281
T0jan merged 6 commits into
sparkmicro:mainfrom
T0jan:local_digykey_api

Conversation

@T0jan
Copy link
Copy Markdown
Collaborator

@T0jan T0jan commented Apr 10, 2025

finally found some time to get it running.

@T0jan
Copy link
Copy Markdown
Collaborator Author

T0jan commented Apr 10, 2025

@eeintech so much for a quick fix to get the api module local... do you think we can skip the new PEP errors for now or will they create problems in deployment?

@eeintech
Copy link
Copy Markdown
Collaborator

eeintech commented Apr 11, 2025

@T0jan Ummm this is news to me... Should we add F824 to setup.cfg?

Btw I tried to test your branch using poetry update only and it kept on complaining with Directory /home/francois/development/Ki-nTree/submodules/digikey-api for digikey-api does not seem to be a Python package.
Which made sense because the submodule wasn't initialized on my computer, so I did git submodule update --init and update worked. I imagine you didn't run into this issue because you added the submodule on your end manually before doing the poetry config? Else how did you get poetry to init the submodule automatically?

@T0jan T0jan force-pushed the local_digykey_api branch from 9b2384b to 6e21b6f Compare April 23, 2025 21:23
@T0jan
Copy link
Copy Markdown
Collaborator Author

T0jan commented Apr 23, 2025

@eeintech Ok so I tried to make the submodule approach working but failed. In theory it should work but I found no way of getting it to work so I switched to just packaging the digikey-api and adding the wheel as a dependency. I hope there isn't a PEP which forbids this approach again 😅 I haven't found one in a quick search.

@eeintech
Copy link
Copy Markdown
Collaborator

eeintech commented Apr 24, 2025

@T0jan Sounds good, let me try this soon!

@T0jan T0jan mentioned this pull request Dec 17, 2025
Open
@T0jan T0jan merged commit bf80ff1 into sparkmicro:main Mar 25, 2026
5 of 9 checks passed
@T0jan
Copy link
Copy Markdown
Collaborator Author

T0jan commented Mar 25, 2026

@eeintech so much for the local package solution, I'm running out of ideas now, may we have to stick with the non pip solution...

[4](https://github.com/sparkmicro/Ki-nTree/actions/runs/23540968655/job/68528338032#step:10:15)
HTTP Error 400: Bad Request | b"<html>\n <head>\n  <title>400 Can't have direct dependency: digikey-api @ file:///home/runner/work/Ki-nTree/Ki-nTree/submodules/digikey_api-1.0.0-py3-none-any.whl. See https://packaging.python.org/specifications/core-metadata for more information.\n \n <body>\n  <h1>400 **Can't have direct dependency: digikey-api** @ file:///home/runner/work/Ki-nTree/Ki-nTree/submodules/digikey_api-1.0.0-py3-none-any.whl. See https://packaging.python.org/specifications/core-metadata for more information.\n  The server could not comply with the request since it is either malformed or otherwise incorrect.<br/><br/>\nCan&#x27;t have direct dependency: digikey-api @ file:///home/runner/work/Ki-nTree/Ki-nTree/submodules/digikey_api-1.0.0-py3-none-any.whl. See https://packaging.python.org/specifications/core-metadata for more information.\n\n\n \n"
Error: Process completed with exit code 1.

https://github.com/sparkmicro/Ki-nTree/actions/runs/23540968655/job/68528338032

@eeintech
Copy link
Copy Markdown
Collaborator

eeintech commented Apr 24, 2026

@T0jan Thanks for trying ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@T0jan @eeintech