Skip to content

Fix search in RTD docs#248

Merged
mcara merged 8 commits intospacetelescope:mainfrom
mcara:fix-rtd-docs-theme-search
May 8, 2026
Merged

Fix search in RTD docs#248
mcara merged 8 commits intospacetelescope:mainfrom
mcara:fix-rtd-docs-theme-search

Conversation

@mcara
Copy link
Copy Markdown
Member

@mcara mcara commented May 8, 2026

Closes #239

Trying to fix search box + other updates

@mcara mcara added this to the Better Awsomeness milestone May 8, 2026
@mcara mcara requested a review from braingram May 8, 2026 05:21
@mcara mcara self-assigned this May 8, 2026
@mcara mcara added the bug Something isn't working label May 8, 2026
@mcara mcara requested a review from a team as a code owner May 8, 2026 05:21
@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.51%. Comparing base (f58bb46) to head (6d0b750).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   93.51%   93.51%           
=======================================
  Files          11       11           
  Lines        2021     2021           
=======================================
  Hits         1890     1890           
  Misses        131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making these updates. The search isn't working when I click the built docs. Let's see if using a newer python (required to pick up the newest sphinx) will fix it.

Comment thread .readthedocs.yml Outdated
Comment thread .readthedocs.yml Outdated
mcara and others added 2 commits May 8, 2026 10:02
Co-authored-by: Brett Graham <brettgraham@gmail.com>
Co-authored-by: Brett Graham <brettgraham@gmail.com>
@braingram
Copy link
Copy Markdown
Contributor

Search is still not working. Looks like there are more things to untangle as the docs theme is still in the docs config:
https://github.com/mcara/tweakwcs/blob/e141f23c4cc34c521325269ef50285bebd6e895f/docs/conf.py#L7

@mcara
Copy link
Copy Markdown
Member Author

mcara commented May 8, 2026

I have no idea what happened by I did remove the stsci_rtd_theme locally and tested it locally to work. I guess I forgot to commit the changes.

Copy link
Copy Markdown
Contributor

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully the search works after merge.

@mcara mcara merged commit 18df9e4 into spacetelescope:main May 8, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working no changelog entry needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs search never completes.

2 participants