Fix an unfortunate unit test#246
Merged
mcara merged 1 commit intospacetelescope:mainfrom Mar 24, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #246 +/- ##
=======================================
Coverage 93.48% 93.48%
=======================================
Files 11 11
Lines 2011 2011
=======================================
Hits 1880 1880
Misses 131 131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pllim
approved these changes
Mar 24, 2026
Contributor
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
Yes, this makes more sense. Thank you!
Contributor
|
BTW the offending code was added 7 years ago in #84 . I wonder why it waited 7 years to cause problem. |
Member
Author
|
it could be just a change in the random generator or the number of runs for the generator has changed and now that code could be generating a different combination. 🤷♂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245
It looks like one of the tests can create a set of points all along a straight line, resulting in a convex hull with too few points to define a polygon. This PR hardcodes a set of test points that are not collinear.