Skip to content

Update dark db#98

Merged
BradleySappington merged 6 commits intospacetelescope:mainfrom
BradleySappington:update_dark_db
May 6, 2026
Merged

Update dark db#98
BradleySappington merged 6 commits intospacetelescope:mainfrom
BradleySappington:update_dark_db

Conversation

@BradleySappington
Copy link
Copy Markdown
Collaborator

Create database (rfp_log_pro) update for the entirety of the dark pipeline run.

@BradleySappington BradleySappington self-assigned this May 1, 2026
self.uncal_files = files
logging.info(f"Ingesting {len(files)} Files: {files}")
if self.db_handler:
# TODO - this is no longer intended to be run in segments so pipeline_cmd is no longer needed
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by segments? Do you mean stages? like the prep stage?

@@ -132,6 +139,12 @@ def prep_pipeline(self, file_list=None):

self.prepped_files.append(prep_output_file_path)
self.qc.check_prep_pipeline() # TODO - speak with rick about what to do on QC Failures
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gracefully exit a prep pipeline instance if a romancal step fails. That means there is something wrong with the data or data model. We shouldn't expect errors in prep pipelines and we wouldn't want to continue either.


# TODO - populate routine based DB entries for rfp_log_pro
# self.db_handler.db_entry.rfp_log_pro.
# verify with rick, no updates in DB for superdark?
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It's not as intense of computation as it was before. Before it was lots of processing, intermediate product used to derive more derived products down stream. Back then I could see keeping more eyes on it. Now I dont see the need for that.

REF_TYPE_DETECTORSTATUS = "DETECTORSTATUS"
REF_TYPE_DISTORTION = "DISTORTION"
REF_TYPE_ETC = "ETC"
REF_TYPE_FGS_MASK = "FGS_MASK"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you do the meta maker classes for this also or not yet? One of us should for Sierra I think.

@BradleySappington BradleySappington marked this pull request as ready for review May 6, 2026 17:42
@BradleySappington BradleySappington merged commit 07597b1 into spacetelescope:main May 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants