Skip to content

Implement Sierra FGS_Mask Code#92

Draft
BradleySappington wants to merge 8 commits intospacetelescope:mainfrom
BradleySappington:implement_sierra_fgs_mask
Draft

Implement Sierra FGS_Mask Code#92
BradleySappington wants to merge 8 commits intospacetelescope:mainfrom
BradleySappington:implement_sierra_fgs_mask

Conversation

@BradleySappington
Copy link
Copy Markdown
Collaborator

Sierra Created the FGS_MASK work. I am cleaning up and turning into pipeline ready function using her code.

@BradleySappington BradleySappington self-assigned this Apr 21, 2026
@BradleySappington BradleySappington marked this pull request as draft April 21, 2026 17:54
@BradleySappington BradleySappington changed the title DRAFT: Implement Sierra FGS_Mask Code Implement Sierra FGS_Mask Code Apr 21, 2026
Copy link
Copy Markdown
Collaborator

@rgcosentino rgcosentino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving a to do I see right now. Keep up the good work!

@@ -1,2 +1,10 @@
dark:
multiprocess_superdark: true
fgs_mask:
Copy link
Copy Markdown
Collaborator

@rgcosentino rgcosentino Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srosagomez Can you please provide details as inline comments for what these variables are and units.

@rgcosentino
Copy link
Copy Markdown
Collaborator

https://soccer.stsci.edu/contentapps/#documents/view/321Z3CB_0191BFQMP00084E/document/321Z9C7_02H9D1YQL0001CG?pageid=321ZB2K_02KC0VD1S000088

Hey @BradleySappington so there is required header information that we need to add to the meta for the FGS mask. Here is the table below it is from this document linked above.

FGS_mask_technical_report.pdf

FITS Header Keyword Meaning Datatype
DETECTOR WFI detector number, in the format WFIXX where XX = 01 through 18 string
AUTHOR RTB Member who created the file string
DATETIME Date of file creation, in the format YYYY-MM-DD string
NBADPIX Number of pixels that are flagged as bad int
CHANGE_NOTE High-level changes to mask derivation (e.g., algorithm or input data type) string

@srosagomez and I chatted and here is what we think:

  • keep the asdf common meta we have and let's keep all of the dq flags set in the FGS workflow as 2**whatever from roman data models
  • have a post pipeline method that then converts the asdf file into a fits file with this meta info, squashing the bit array into 0's and 1's, and generating a fits file

Thoughts? Can be discussed at hack session next week but I think this makes sense. It allows us to make a product in standard asdf format so RDMT can monitor it and it's like everything else, but also we give the ability to deliver a product to the customer in the format they request/require separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants