[WIP]: Use niriss_ghost repo as source of ghost-related code#754
Open
bhilbert4 wants to merge 3 commits intospacetelescope:masterfrom
Open
[WIP]: Use niriss_ghost repo as source of ghost-related code#754bhilbert4 wants to merge 3 commits intospacetelescope:masterfrom
bhilbert4 wants to merge 3 commits intospacetelescope:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shifts the calculation of optical ghost locations to the niriss_ghost repository, which is maintained by the NIRISS team. This repository contains the master copy of the ghost gap file, as well as several functions which calculate a corresponding ghost's location on the detector given a source's location. By switching Mirage over to use this repo, we can be sure that it always has access to the latest ghost gap file and algorithms.
These updates have not been tested yet. The functions in niriss_ghost are going to be updated shortly. We should wait for these updates to be made and make any necessary tweaks to Mirage before doing any testing.