subscriptions in the MAST API#159
Draft
ttdu wants to merge 5 commits intospacetelescope:mainfrom
Draft
Conversation
Collaborator
Author
|
@snbianco the rest of the notebook is not ready for review, but I wanted to ask about the MissionsMast class defaulting to HST. in this case, when I forgot to set the mission, it tried to download the files and ended up with a lot of nonsense, because the JWST URIs don't work for HST. what do you think about throwing an error when users don't initialize the mission, instead of defaulting to HST? |
Contributor
|
I may be able to do one better. I notice in the subscription JSON that mission is included. I could make it so that AQ uses that value and defaults to the mission attribute if it's not present (and fails gracefully if that doesn't work either). There's a few things I want to finish first, but I should be able to make a PR sometime this sprint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.