ASB-36065: Adding validation for CCSP and MCCM filenames#36
Open
astrojimig wants to merge 7 commits intodevfrom
Open
ASB-36065: Adding validation for CCSP and MCCM filenames#36astrojimig wants to merge 7 commits intodevfrom
astrojimig wants to merge 7 commits intodevfrom
Conversation
Collaborator
|
Thanks Julie, this is sounding great!! I'll aim to provide any initial high-level feedback before I go on vacation Friday, and do more detailed checks when I get back later in May. |
Collaborator
|
Agreed with Adrian Julie this is looking great! The commands are working for me and returning what I would expect for various HLPS.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for validating CCSP and MCCM filenames!
Overview of changes:
hlsp_filename.pymodule into two files:filename_fields.pyandfilename_classes.pyto make things a little more modularCCSPFilenameandMCCMFilenameclasses infilename_classes.py, along with the oldHLSPFilename- where the order of fields for each is defined. The type is determined by the prefix: If a file starts withhlsp_, it gets routed to the HLSPFilename validator, etc.HlspFieldhas been renamed toPrefixFieldand now accepts hlsp, ccsp, and mccm.The entry point is identical to what it was before, for example:
Try it out yourself and let me know what you find! If you have any suggestions for more test cases (specific edge cases or weird things that should fail), that would be especially helpful.
Still to do: